Page MenuHomePhabricator

Abstract out BlockAssembler options
ClosedPublic

Authored by deadalnix on Sep 13 2019, 16:35.

Details

Summary

This is a partial backport of Core PR9868

It was modified as to extract the required infos from the config and only use the option object going forward, which avoid having two source of truth.

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
mineroptions
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7551
Build 13142: Bitcoin ABC Buildbot (legacy)
Build 13141: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Sep 13 2019, 20:39
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/miner.h
169 ↗(On Diff #11289)

nExcesiveBlockSize -> nExcessiveBlockSize

This revision now requires changes to proceed.Sep 13 2019, 20:39

nExcesiveBlockSize -> nExcessiveBlockSize

Fabien added inline comments.
src/miner.cpp
64 ↗(On Diff #11308)

I don't understand how this can build:
blockMinFeeRate is a CFeeRate which has an explicit constructor. Passing an Amount should then raise a compiler error ?

92 ↗(On Diff #11308)

Is the IsArgSet() call useful ? The default value for Options.nMaxGeneratedBlockSize is DEFAULT_MAX_GENERATED_BLOCK_SIZE so if -blockmaxsize is not set the value is always DEFAULT_MAX_GENERATED_BLOCK_SIZE.

Ping. This has not recieved any substancial review for 10 days now.

This revision is now accepted and ready to land.Sep 23 2019, 16:20