Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGf4336441a5d8: Abstract out BlockAssembler options
rABCf4336441a5d8: Abstract out BlockAssembler options

Summary

This is a partial backport of Core PR9868

It was modified as to extract the required infos from the config and only use the option object going forward, which avoid having two source of truth.

Test Plan

make check
./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 13 2019, 16:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2019, 16:35

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix mentioned this in D3471: Merge #9868: Abstract out the command line options for block assembly.Sep 13 2019, 16:37

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7448: Diff 11289.Sep 13 2019, 16:44

jasonbcox requested changes to this revision.Sep 13 2019, 20:39

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/miner.h
169 ↗	(On Diff #11289)	nExcesiveBlockSize -> nExcessiveBlockSize

This revision now requires changes to proceed.Sep 13 2019, 20:39

nExcesiveBlockSize -> nExcessiveBlockSize

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7457: Diff 11308.Sep 14 2019, 09:24

deadalnix added a child revision: D4081: Run miner_tests with fixed options.Sep 14 2019, 11:13

Fabien added a subscriber: Fabien.Sep 16 2019, 08:55

Fabien added inline comments.

src/miner.cpp
64 ↗	(On Diff #11308)	I don't understand how this can build: `blockMinFeeRate` is a `CFeeRate` which has an explicit constructor. Passing an `Amount` should then raise a compiler error ?
92 ↗	(On Diff #11308)	Is the `IsArgSet()` call useful ? The default value for `Options.nMaxGeneratedBlockSize` is `DEFAULT_MAX_GENERATED_BLOCK_SIZE` so if `-blockmaxsize` is not set the value is always `DEFAULT_MAX_GENERATED_BLOCK_SIZE`.