Page MenuHomePhabricator

debug log number of unknown wallet records on load
ClosedPublic

Authored by fpelliccioni on Sep 13 2019, 22:29.

Details

Summary

This would have saved me some time during wallet debugging, with minimal logging clutter.

Backport of Bitcoin Core PR12888
https://github.com/bitcoin/bitcoin/pull/12888

Test Plan
  1. make check-all
  2. ./src/bitcoind -regtest
  3. Verify that "Unknown wallet records:" appears in the log file.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-39439e5ab
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7520
Build 13080: Bitcoin ABC Buildbot (legacy)
Build 13079: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 14 2019, 07:52
deadalnix requested changes to this revision.Sep 14 2019, 07:56

While the code looks correct, it doesn't seems that there is a test case for this behavior, and therefore the test plan don't test for anything useful.

This revision now requires changes to proceed.Sep 14 2019, 07:56
fpelliccioni edited the test plan for this revision. (Show Details)

Test plan fixed.

This revision is now accepted and ready to land.Sep 20 2019, 16:15