banman: add thread annotations and mark members const where possible
ClosedPublic
Actions

Authored by deadalnix on Sep 21 2019, 11:26.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING697f4827b1e5: banman: add thread annotations and mark members const where possible
rABC697f4827b1e5: banman: add thread annotations and mark members const where possible

Summary

Also remove misleading comment. ClearBanned is used by rpc as well.

This is a partial backport of Core PR14605 : https://github.com/bitcoin/bitcoin/pull/14605/commits/daae598feb034f2f56e0b00ecfb4854d693d3641

Depends on D4126

Test Plan

Build with clang and check no warning is thrown

Diff Detail

Repository

rABC Bitcoin ABC

Branch

bananot

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7537
Build 13114: Bitcoin ABC Buildbot (legacy)
Build 13113: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 21 2019, 11:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 21 2019, 11:26

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7537: Diff 13052.Sep 21 2019, 11:36

deadalnix added a child revision: D4128: banman: reformulate nBanUtil calculation.Sep 21 2019, 11:41

Fabien accepted this revision.Sep 22 2019, 11:20

Fabien edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Sep 22 2019, 11:20

Closed by commit rABC697f4827b1e5: banman: add thread annotations and mark members const where possible (authored by Cory Fields <cory-nospam-@coryfields.com>, committed by deadalnix). · Explain WhySep 22 2019, 12:41

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC697f4827b1e5: banman: add thread annotations and mark members const where possible.

deadalnix added a commit: rSTAGING697f4827b1e5: banman: add thread annotations and mark members const where possible.Sep 27 2019, 22:46

Revision Contents
Changeset List

Path

Size

src/

banman.h

7 lines

Diff 13052

View Options

banman: add thread annotations and mark members const where possibleClosedPublicActions