banman: reformulate nBanUtil calculation
ClosedPublic
Actions

Authored by deadalnix on Sep 21 2019, 11:41.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING8c7329748182: banman: reformulate nBanUtil calculation
rABC8c7329748182: banman: reformulate nBanUtil calculation

Summary

Avoid reassigning parameters.

This is a partial backport of Core PR14605 : https://github.com/bitcoin/bitcoin/pull/14605/commits/1ffa4ce27d4ea6c1067d8984455df97994c7713e

Depends on D4127

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

bancalc

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7538
Build 13116: Bitcoin ABC Buildbot (legacy)
Build 13115: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 21 2019, 11:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 21 2019, 11:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7538: Diff 13053.Sep 21 2019, 11:50

deadalnix added a child revision: D4129: banman: Add, use CBanEntry ctor that takes ban reason.Sep 21 2019, 11:53

Fabien accepted this revision.Sep 22 2019, 11:26

This revision is now accepted and ready to land.Sep 22 2019, 11:26

Closed by commit rABC8c7329748182: banman: reformulate nBanUtil calculation (authored by Carl Dong <accounts@carldong.me>, committed by deadalnix). · Explain WhySep 22 2019, 12:43

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC8c7329748182: banman: reformulate nBanUtil calculation.

deadalnix added a commit: rSTAGING8c7329748182: banman: reformulate nBanUtil calculation.Sep 27 2019, 22:47

Revision Contents
Changeset List

Path

Size

src/

banman.cpp

10 lines

Diff 13053

View Options

banman: reformulate nBanUtil calculationClosedPublicActions