banman: Add, use CBanEntry ctor that takes ban reason
ClosedPublic
Actions

Authored by deadalnix on Sep 21 2019, 11:53.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING8ab0ff176909: banman: Add, use CBanEntry ctor that takes ban reason
rABC8ab0ff176909: banman: Add, use CBanEntry ctor that takes ban reason

Summary

This is a partial backport of Core PR14605 : https://github.com/bitcoin/bitcoin/pull/14605/commits/c2e04d37f3841d109c1fe60693f9622e2836cc29

Depends on D4128

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

banreason

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7539
Build 13118: Bitcoin ABC Buildbot (legacy)
Build 13117: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 21 2019, 11:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 21 2019, 11:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix added a child revision: D4130: scripted-diff: batch-recase BanMan variables.Sep 21 2019, 11:56

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7539: Diff 13054.Sep 21 2019, 12:04

Fabien accepted this revision.Sep 22 2019, 11:28

This revision is now accepted and ready to land.Sep 22 2019, 11:28

Closed by commit rABC8ab0ff176909: banman: Add, use CBanEntry ctor that takes ban reason (authored by Carl Dong <accounts@carldong.me>, committed by deadalnix). · Explain WhySep 22 2019, 12:45

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC8ab0ff176909: banman: Add, use CBanEntry ctor that takes ban reason.

deadalnix added a commit: rSTAGING8ab0ff176909: banman: Add, use CBanEntry ctor that takes ban reason.Sep 27 2019, 22:47

Revision Contents
Changeset List

Path

Size

src/

addrdb.h

5 lines

banman.cpp

3 lines

Diff 13054

View Options

src/addrdb.h