Page MenuHomePhabricator
Differential D4390

Automatically initialize RNG on first use.
ClosedPublic
Actions

Authored by nakihito on Nov 5 2019, 22:46.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGdd5cc37d0c1d: Automatically initialize RNG on first use.
rABCdd5cc37d0c1d: Automatically initialize RNG on first use.
Summary

Partial backport of Core PR14955
https://github.com/bitcoin/bitcoin/pull/14955/commits/05fde14e3afe6f7156ebb6df6cd0e3ae12635b89

Depends on D4389

Test Plan
make check
test_runner.py
./bench/bench_bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14955-3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8000
Build 13998: Bitcoin ABC Buildbot (legacy)
Build 13997: arc lint + arc unit

Event Timeline

nakihito created this revision.Nov 5 2019, 22:46
Owners added a reviewer: Restricted Owners Package.Nov 5 2019, 22:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2019, 22:46
teamcity added a comment.Nov 5 2019, 22:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the summary of this revision. (Show Details)Nov 5 2019, 22:46
nakihito added a parent revision: D4389: Don't log RandAddSeedPerfmon details.
nakihito added a child revision: D4391: Rename some hardware RNG related functions.Nov 5 2019, 22:47
teamcity added a comment.Nov 5 2019, 23:04

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8000: Diff 13941.Nov 5 2019, 23:04
jasonbcox accepted this revision.Nov 5 2019, 23:06
This revision is now accepted and ready to land.Nov 5 2019, 23:06
Closed by commit rABCdd5cc37d0c1d: Automatically initialize RNG on first use. (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyNov 8 2019, 15:57
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCdd5cc37d0c1d: Automatically initialize RNG on first use..
nakihito added a commit: rSTAGINGdd5cc37d0c1d: Automatically initialize RNG on first use..Apr 7 2020, 21:38

Revision Contents
Changeset List

PathSize
src/
bench/
2 lines
7 lines
64 lines
test/
1 line

Diff 13941

View Options

src/bench/bench_bitcoin.cpp

Loading...
View Options

src/random.h

Loading...
View Options

src/random.cpp

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...