Page MenuHomePhabricator
Differential D4391

Rename some hardware RNG related functions
ClosedPublic
Actions

Authored by nakihito on Nov 5 2019, 22:47.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGa9f1617a330a: Rename some hardware RNG related functions
rABCa9f1617a330a: Rename some hardware RNG related functions
Summary

Partial backport of Core PR14955
https://github.com/bitcoin/bitcoin/pull/14955/commits/d3f54d1c82b131d817b20cd9daa75f9d3c9475e1

Depends on D4390

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14955-4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8001
Build 14000: Bitcoin ABC Buildbot (legacy)
Build 13999: arc lint + arc unit

Event Timeline

nakihito created this revision.Nov 5 2019, 22:47
Owners added a reviewer: Restricted Owners Package.Nov 5 2019, 22:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2019, 22:47
nakihito planned changes to this revision.Nov 5 2019, 22:47
teamcity added a comment.Nov 5 2019, 22:48

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito updated this revision to Diff 13943.Nov 5 2019, 22:50

Reformatted comment.

teamcity added a comment.Nov 5 2019, 22:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito added a child revision: D4392: Add thread safety annotations to RNG state.Nov 5 2019, 22:52
Harbormaster completed remote builds in B8001: Diff 13942.Nov 5 2019, 23:05
teamcity added a comment.Nov 5 2019, 23:05

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Nov 5 2019, 23:07

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8002: Diff 13943.Nov 5 2019, 23:07
jasonbcox accepted this revision.Nov 5 2019, 23:08
This revision is now accepted and ready to land.Nov 5 2019, 23:08
Closed by commit rABCa9f1617a330a: Rename some hardware RNG related functions (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyNov 8 2019, 16:00
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCa9f1617a330a: Rename some hardware RNG related functions.
nakihito added a commit: rSTAGINGa9f1617a330a: Rename some hardware RNG related functions.Apr 7 2020, 21:38

Revision Contents
Changeset List

PathSize
src/
21 lines

Diff 13942

View Options

src/random.cpp

Loading...