Add thread safety annotations to RNG state
ClosedPublic
Actions

Authored by nakihito on Nov 5 2019, 22:52.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING10c8a5681f93: Add thread safety annotations to RNG state
rABC10c8a5681f93: Add thread safety annotations to RNG state

Summary

Partial backport of Core PR14955
https://github.com/bitcoin/bitcoin/pull/14955/commits/aae8b9bf0f4fd2b801ee72cf191588c8b3a67c3c

Depends on D4391

Test Plan

contrib/teamcity/build-configurations.sh build-werror

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Nov 5 2019, 22:52

Owners added a reviewer: Restricted Owners Package.Nov 5 2019, 22:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2019, 22:52

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the summary of this revision. (Show Details)Nov 5 2019, 22:52

nakihito added a parent revision: D4391: Rename some hardware RNG related functions.

nakihito added a child revision: D4393: Abstract out seeding/extracting entropy into RNGState::MixExtract.Nov 5 2019, 22:55

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8003: Diff 13944.Nov 5 2019, 23:08

jasonbcox accepted this revision.Nov 5 2019, 23:09

This revision is now accepted and ready to land.Nov 5 2019, 23:09

Closed by commit rABC10c8a5681f93: Add thread safety annotations to RNG state (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyNov 8 2019, 16:01

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC10c8a5681f93: Add thread safety annotations to RNG state.

nakihito added a commit: rSTAGING10c8a5681f93: Add thread safety annotations to RNG state.Apr 7 2020, 21:38

Revision Contents
Changeset List

Path

Size

src/

random.cpp

6 lines

Diff 13990

View Options

Add thread safety annotations to RNG stateClosedPublicActions