Abstract out seeding/extracting entropy into RNGState::MixExtract
ClosedPublic
Actions

Authored by nakihito on Nov 5 2019, 22:55.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING495cb1dc449e: Abstract out seeding/extracting entropy into RNGState::MixExtract
rABC495cb1dc449e: Abstract out seeding/extracting entropy into RNGState::MixExtract

Summary

Partial backport of Core PR14955
https://github.com/bitcoin/bitcoin/pull/14955/commits/2ccc3d3aa346e96206281a391bc29874cf5ee7f4

Depends on D4392

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14955-6

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8004
Build 14006: Bitcoin ABC Buildbot (legacy)
Build 14005: arc lint + arc unit

Event Timeline

nakihito created this revision.Nov 5 2019, 22:55

Owners added a reviewer: Restricted Owners Package.Nov 5 2019, 22:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2019, 22:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito added a child revision: D4394: Integrate util/system's CInit into RNGState.Nov 5 2019, 22:58

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8004: Diff 13945.Nov 5 2019, 23:12

jasonbcox accepted this revision.Nov 5 2019, 23:21

jasonbcox added inline comments.

src/random.cpp
318	Fix comment style

This revision is now accepted and ready to land.Nov 5 2019, 23:21

Fixed comment formatting.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8018: Diff 13968.Nov 6 2019, 19:18

Closed by commit rABC495cb1dc449e: Abstract out seeding/extracting entropy into RNGState::MixExtract (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyNov 8 2019, 16:04

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC495cb1dc449e: Abstract out seeding/extracting entropy into RNGState::MixExtract.

nakihito added a commit: rSTAGING495cb1dc449e: Abstract out seeding/extracting entropy into RNGState::MixExtract.Apr 7 2020, 21:38

Revision Contents
Changeset List

Path

Size

src/

crypto/

sha512.h

2 lines

random.cpp

62 lines

Diff 13945

View Options

src/crypto/sha512.h