Page MenuHomePhabricator
Differential D4796

Backport PR11309: Minor cleanups for AcceptToMemoryPool
ClosedPublic
Actions

Authored by markblundeberg on Dec 22 2019, 03:28.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING0cc1205d9877: Backport PR11309: Minor cleanups for AcceptToMemoryPool
rABC0cc1205d9877: Backport PR11309: Minor cleanups for AcceptToMemoryPool
Summary

This is based on #11309 https://github.com/bitcoin/bitcoin/pull/11309/files however
the removal of fLimitFree and the fix for reorgs was already done in D4745.
So, this is basically just renaming fOverrideMempoolLimit -> bypass_limits,
removing defaultness of two args, and making sure that literal arguments are
documented with /* */. (test_accept from D3079 stays as default arg, like it
is in Core today)

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11309
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8679
Build 15344: Default Diff Build & Tests
Build 15343: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Dec 22 2019, 03:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 22 2019, 03:28
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 22 2019, 03:28

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg planned changes to this revision.Dec 22 2019, 03:30
markblundeberg added inline comments.
src/test/txvalidationcache_tests.cpp
34

oops, missed /* pfMissingInputs */ here

teamcity added a comment.Dec 22 2019, 03:40

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8679: Diff 15066.Dec 22 2019, 03:40
markblundeberg updated this revision to Diff 15067.Dec 22 2019, 03:46
markblundeberg edited the summary of this revision. (Show Details)

args defaultness, also missed one place

teamcity added a comment.Dec 22 2019, 03:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg mentioned this in D4280: Minor cleanups for AcceptToMemoryPool.Dec 22 2019, 03:50
teamcity added a comment.Dec 22 2019, 03:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8680: Diff 15067.Dec 22 2019, 03:57
deadalnix accepted this revision.Dec 23 2019, 00:05
This revision is now accepted and ready to land.Dec 23 2019, 00:05
Closed by commit rABC0cc1205d9877: Backport PR11309: Minor cleanups for AcceptToMemoryPool (authored by MarcoFalke <falke.marco@gmail.com>, committed by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyDec 23 2019, 02:08
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC0cc1205d9877: Backport PR11309: Minor cleanups for AcceptToMemoryPool.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING0cc1205d9877: Backport PR11309: Minor cleanups for AcceptToMemoryPool.Apr 7 2020, 22:13

Revision Contents
Changeset List

PathSize
src/
rpc/
6 lines
test/
2 lines
6 lines
5 lines
3 lines
23 lines
wallet/
6 lines

Diff 15066

View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/test/txvalidation_tests.cpp

Loading...
View Options

src/test/txvalidationcache_tests.cpp

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...