Page MenuHomePhabricator

Backport PR11309: Minor cleanups for AcceptToMemoryPool
ClosedPublic

Authored by markblundeberg on Dec 22 2019, 03:28.

Details

Summary

This is based on #11309 https://github.com/bitcoin/bitcoin/pull/11309/files however
the removal of fLimitFree and the fix for reorgs was already done in D4745.
So, this is basically just renaming fOverrideMempoolLimit -> bypass_limits,
removing defaultness of two args, and making sure that literal arguments are
documented with /* */. (test_accept from D3079 stays as default arg, like it
is in Core today)

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11309
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8680
Build 15346: Default Diff Build & Tests
Build 15345: arc lint + arc unit

Event Timeline

markblundeberg added inline comments.
src/test/txvalidationcache_tests.cpp
34 ↗(On Diff #15066)

oops, missed /* pfMissingInputs */ here

markblundeberg edited the summary of this revision. (Show Details)

args defaultness, also missed one place

This revision is now accepted and ready to land.Dec 23 2019, 00:05