Page MenuHomePhabricator
Differential D4812

finish backporting PR9602 : remove unused priority number in mempool mapDeltas
ClosedPublic
Actions

Authored by markblundeberg on Dec 31 2019, 03:39.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGbe7332327629: finish backporting PR9602 : remove unused priority number in mempool mapDeltas
rABCbe7332327629: finish backporting PR9602 : remove unused priority number in mempool mapDeltas
Summary

D4778 and D4787 removed all effect of this number.

(in a follow-up diff, I will remove the RPC parameter slot)

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cleanup5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8699
Build 15384: Default Diff Build & Tests
Build 15383: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Dec 31 2019, 03:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 31 2019, 03:39
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 31 2019, 03:39

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a child revision: D4813: finish backporting PR9602 : remove ineffective parameter from `prioritisetransaction` RPC.Dec 31 2019, 03:41
teamcity added a comment.Dec 31 2019, 03:54

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8699: Diff 15095.Dec 31 2019, 03:54
deadalnix accepted this revision.Jan 2 2020, 17:47
This revision is now accepted and ready to land.Jan 2 2020, 17:47
Closed by commit rABCbe7332327629: finish backporting PR9602 : remove unused priority number in mempool mapDeltas (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyJan 3 2020, 01:46
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABCbe7332327629: finish backporting PR9602 : remove unused priority number in mempool mapDeltas.
markblundeberg added inline comments.Jan 4 2020, 02:01
src/rpc/mining.cpp
276 ↗(On Diff #15125)

oops, messed up the spacing here.

markblundeberg mentioned this in D4829: [rpc] Finish backporting changes to prioritisetransaction's priority_delta argument.Jan 4 2020, 02:09
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABC7dbf277ad363: [rpc] Finish backporting changes to prioritisetransaction's priority_delta….Jan 5 2020, 03:13
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGINGbe7332327629: finish backporting PR9602 : remove unused priority number in mempool mapDeltas.Apr 7 2020, 22:15
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGING7dbf277ad363: [rpc] Finish backporting changes to prioritisetransaction's priority_delta….
PiRK mentioned this in D12168: Fix BlockAssembler::AddToBlock logging.Oct 7 2022, 06:40
PiRK mentioned this in rABCe4ea0649bdbc: Fix BlockAssembler::AddToBlock logging.Oct 7 2022, 09:55

Revision Contents
Changeset List

PathSize
src/
rpc/
2 lines
14 lines
10 lines
25 lines
11 lines

Diff 15095

View Options

src/rpc/client.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.cpp

Loading...