Page MenuHomePhabricator

Extract the flag selection logic out of CheckBlock
ClosedPublic

Authored by deadalnix on Sep 4 2017, 12:02.

Details

Summary

As it can be reused and/or tested when modified.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
blockflags
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 823
Build 823: arc lint + arc unit

Event Timeline

Seems ok from here, wonder if we could avoid the repetition of this check

if (VersionBitsState(pindex->pprev, consensusparams,
                     Consensus::DEPLOYMENT_CSV,
                     versionbitscache) == THRESHOLD_ACTIVE) {

@sickpig The check is cached, so I don't think it is that big of a deal. Later on we can set the block in stone and remove the check.

dagurval added inline comments.
src/validation.cpp
1726

Comment lies, this does not enforce sequence locks.

Same comment is duplicated further down, where it does not enforce checksequence

This revision is now accepted and ready to land.Sep 7 2017, 19:22
This revision was automatically updated to reflect the committed changes.