Extract the flag selection logic out of CheckBlock
ClosedPublic
Actions

Authored by deadalnix on Sep 4 2017, 12:02.

Details

Reviewers

freetrader
CCulianu
sickpig
dagurval

Group Reviewers

Restricted Project

Commits

rSTAGING730ae53b947b: Extract the flag selection logic out of CheckBlock
rABC730ae53b947b: Extract the flag selection logic out of CheckBlock

Summary

As it can be reused and/or tested when modified.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

blockflags

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 823
Build 823: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 4 2017, 12:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2017, 12:02

Harbormaster completed remote builds in B823: Diff 1309.Sep 4 2017, 12:02

Seems ok from here, wonder if we could avoid the repetition of this check

if (VersionBitsState(pindex->pprev, consensusparams,
                     Consensus::DEPLOYMENT_CSV,
                     versionbitscache) == THRESHOLD_ACTIVE) {

deadalnix added a child revision: D527: Check transaction that enter the mempool against the flags required for the current block rather than a minimal set of mandatory flags..Sep 5 2017, 20:01

sickpig accepted this revision as: sickpig.Sep 6 2017, 20:10

@sickpig The check is cached, so I don't think it is that big of a deal. Later on we can set the block in stone and remove the check.

dagurval added a subscriber: dagurval.Sep 7 2017, 18:38

dagurval added inline comments.

src/validation.cpp
1726	Comment lies, this does not enforce sequence locks. Same comment is duplicated further down, where it does not enforce checksequence

Fix comments

Harbormaster completed remote builds in B849: Diff 1349.Sep 7 2017, 19:20

dagurval accepted this revision.Sep 7 2017, 19:22

This revision is now accepted and ready to land.Sep 7 2017, 19:22

Closed by commit rABC730ae53b947b: Extract the flag selection logic out of CheckBlock (authored by deadalnix, committed by deadalnix). · Explain WhySep 7 2017, 19:24

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

66 lines

Diff 1309

View Options

Extract the flag selection logic out of CheckBlockClosedPublicActions