Page MenuHomePhabricator
Differential D5419

[wallet] Delete unused account functions
ClosedPublic
Actions

Authored by nakihito on Mar 3 2020, 22:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING224a4cd81747: [wallet] Delete unused account functions
rABC224a4cd81747: [wallet] Delete unused account functions
Summary

Deletes:

  • ReadAccount
  • WriteAccount
  • EraseAccount
  • DeleteLabel
  • GetLabelDestination

Partial backport of Core PR13825
https://github.com/bitcoin/bitcoin/pull/13825/commits/f85988ca7440e9ac3b33250d03ff68befb9bb51c
https://github.com/bitcoin/bitcoin/pull/13825/commits/53038b47ec51ac455f448b2d324a2bc032c45d68

Depends on D5316

Test Plan
ninja check
test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Mar 3 2020, 22:20
Owners added a reviewer: Restricted Owners Package.Mar 3 2020, 22:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2020, 22:20
teamcity edited the summary of this revision. (Show Details)Mar 3 2020, 22:20

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 3 2020, 22:20

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B9717: Diff 16750.Mar 3 2020, 22:31
teamcity added a comment.Mar 3 2020, 22:31

Build Bitcoin-ABC / Diffs / Diff Testing passed.

nakihito added a child revision: D5422: [wallet] Remove CAccount and Update zapwallettxes comment.Mar 3 2020, 22:47
Fabien requested changes to this revision.Mar 4 2020, 08:18
Fabien added a subscriber: Fabien.

Please run the wallet functional tests as part of the test plan: ./test/functional/test_runner.py wallet_*. (wallet_backup is part of the extended tests).

This revision now requires changes to proceed.Mar 4 2020, 08:18
nakihito requested review of this revision.Mar 4 2020, 18:59
nakihito edited the test plan for this revision. (Show Details)

Updated test plan.

Fabien accepted this revision.Mar 5 2020, 07:42
This revision is now accepted and ready to land.Mar 5 2020, 07:42
Closed by commit rABC224a4cd81747: [wallet] Delete unused account functions (authored by nakihito). · Explain WhyMar 6 2020, 19:36
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC224a4cd81747: [wallet] Delete unused account functions.
nakihito added a commit: rSTAGING224a4cd81747: [wallet] Delete unused account functions.Apr 7 2020, 23:16
jasonbcox mentioned this in D7823: Cleanup unused old_label variable.Oct 8 2020, 16:05
jasonbcox mentioned this in rABCba9b046e0fd1: Cleanup unused old_label variable.Oct 8 2020, 21:01

Revision Contents
Changeset List

PathSize
src/
wallet/
16 lines
4 lines
49 lines
4 lines
16 lines

Diff 16815

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...