Page MenuHomePhabricator

[backport#15288] Remove uses of CheckFinalTx in wallet code
ClosedPublic

Authored by majcosta on Apr 23 2020, 16:48.

Details

Summary

80f52a2267f44a9cae4440615df3ff989be1579c This commit does not change behavior. (Russell Yanofsky)


This is a follow up to D5804 and a partial backport of Core PR15288

Test Plan
cmake .. -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug -DBUILD_BITCOIN_WALLET=OFF
ninja check check-functional
cmake .. -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check check-functional

Diff Detail

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Apr 23 2020, 22:34
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/interfaces/chain.cpp
139 ↗(On Diff #19059)

Why flags?

src/interfaces/chain.h
9 ↗(On Diff #19059)

You can forward declare instead of adding includes, because you only pass by ref.

This revision now requires changes to proceed.Apr 23 2020, 22:34

replaced header includes with forward declarations and removed optional flag argument to contextualCheckTransactionForCurrentBlock

This revision is now accepted and ready to land.Apr 23 2020, 23:38