Page MenuHomePhabricator
Differential D5826

[backport#15288] Remove use of GetTransactionAncestry in wallet code
ClosedPublic
Actions

Authored by majcosta on Apr 24 2020, 17:03.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGff57e58d8a8f: [backport#15288] Remove use of GetTransactionAncestry in wallet code
rABCff57e58d8a8f: [backport#15288] Remove use of GetTransactionAncestry in wallet code
Summary

cd32160af0528cc746968ee0eadf4f63c98665f2 This commit does not change behavior. (Russell Yanofsky)

Depends on D5820

This is a partial backport of Core PR15288

Test Plan
cmake .. -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15288
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/interfaces/chain.h:14CHEADER1C compatibility header found in a C++ file
Unit
No Test Coverage
Build Status
Buildable 10380
Build 18581: Default Diff Build & Tests
Build 18580: arc lint + arc unit

Event Timeline

majcosta created this revision.Apr 24 2020, 17:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 24 2020, 17:03
teamcity edited the summary of this revision. (Show Details)Apr 24 2020, 17:04

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 24 2020, 17:04

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 24 2020, 17:14

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10380: Diff 19087.Apr 24 2020, 17:14
majcosta added a child revision: D5831: [backport#15288] Remove use of CalculateMemPoolAncestors in wallet code.Apr 24 2020, 19:18
majcosta updated this revision to Diff 19109.Apr 24 2020, 23:31

removed C header in favor of <cstddef>

teamcity added a comment.Apr 24 2020, 23:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 24 2020, 23:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10395: Diff 19109.Apr 24 2020, 23:48
deadalnix accepted this revision.Apr 25 2020, 20:56
This revision is now accepted and ready to land.Apr 25 2020, 20:56
Closed by commit rABCff57e58d8a8f: [backport#15288] Remove use of GetTransactionAncestry in wallet code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyApr 25 2020, 23:06
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCff57e58d8a8f: [backport#15288] Remove use of GetTransactionAncestry in wallet code.
majcosta added a commit: rSTAGINGff57e58d8a8f: [backport#15288] Remove use of GetTransactionAncestry in wallet code.May 5 2020, 19:08

Revision Contents
Changeset List

PathSize
src/
interfaces/
6 lines
4 lines
wallet/
4 lines

Diff 19087

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...