Page MenuHomePhabricator

[backport#15288] Remove use of AcceptToMemoryPool in wallet code
ClosedPublic

Authored by majcosta on Apr 28 2020, 03:59.

Details

Summary

d02b34c8a8bd446c9620fe626b4379617f9a9639 This commit does not change behavior. (Russell Yanofski)


Depends on D5858

This is a partial backport of Core PR15288

Test Plan
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug -DBUILD_BITCOIN_WALLET=OFF
ninja check-all
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15288
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10443
Build 18706: Default Diff Build & Tests
Build 18705: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Apr 28 2020, 13:45
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/interfaces/chain.cpp
154

Take config as a parameter instead of fetching more global state.

This revision now requires changes to proceed.Apr 28 2020, 13:45

passing global config as a parameter now

This revision is now accepted and ready to land.Apr 28 2020, 15:55