Page MenuHomePhabricator
Differential D5866

[backport#15288] Remove use of AcceptToMemoryPool in wallet code
ClosedPublic
Actions

Authored by majcosta on Apr 28 2020, 03:59.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING72c645190b30: [backport#15288] Remove use of AcceptToMemoryPool in wallet code
rABC72c645190b30: [backport#15288] Remove use of AcceptToMemoryPool in wallet code
Summary

d02b34c8a8bd446c9620fe626b4379617f9a9639 This commit does not change behavior. (Russell Yanofski)

Depends on D5858

This is a partial backport of Core PR15288

Test Plan
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug -DBUILD_BITCOIN_WALLET=OFF
ninja check-all
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15288
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10443
Build 18706: Default Diff Build & Tests
Build 18705: arc lint + arc unit

Event Timeline

majcosta created this revision.Apr 28 2020, 03:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 28 2020, 03:59
teamcity edited the summary of this revision. (Show Details)Apr 28 2020, 03:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 28 2020, 03:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 28 2020, 04:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10443: Diff 19189.Apr 28 2020, 04:09
majcosta added a child revision: D5867: [backport#15288] circular-dependencies: Avoid treating some .h/.cpp files as a unit.Apr 28 2020, 06:14
deadalnix requested changes to this revision.Apr 28 2020, 13:45
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/interfaces/chain.cpp
154

Take config as a parameter instead of fetching more global state.

This revision now requires changes to proceed.Apr 28 2020, 13:45
majcosta updated this revision to Diff 19201.Apr 28 2020, 15:22

passing global config as a parameter now

teamcity added a comment.Apr 28 2020, 15:22

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 28 2020, 15:32

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10452: Diff 19201.Apr 28 2020, 15:32
deadalnix accepted this revision.Apr 28 2020, 15:55
This revision is now accepted and ready to land.Apr 28 2020, 15:55
Closed by commit rABC72c645190b30: [backport#15288] Remove use of AcceptToMemoryPool in wallet code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyApr 28 2020, 18:22
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC72c645190b30: [backport#15288] Remove use of AcceptToMemoryPool in wallet code.
majcosta added a commit: rSTAGING72c645190b30: [backport#15288] Remove use of AcceptToMemoryPool in wallet code.May 5 2020, 19:11

Revision Contents
Changeset List

PathSize
src/
interfaces/
12 lines
10 lines
wallet/
2 lines
15 lines

Diff 19189

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...