Page MenuHomePhabricator
Differential D5870

[backport#15531] Merge #15531: Suggested interfaces::Chain cleanups from #15288
ClosedPublic
Actions

Authored by majcosta on Apr 28 2020, 08:43.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGe6069992d766: [backport#15531] Merge #15531: Suggested interfaces::Chain cleanups from #15288
rABCe6069992d766: [backport#15531] Merge #15531: Suggested interfaces::Chain cleanups from #15288
Summary

4d4e4c6448 Suggested interfaces::Chain cleanups from #15288 (Russell Yanofsky)

Pull request description:

Mostly documentation improvements requested in the last review of #15288 before it was merged (https://github.com/bitcoin/bitcoin/pull/15288#pullrequestreview-210241864)

Tree-SHA512: 64e912520bbec20a44032f265a8cf3f11ad7f5126c8626b5ad5e888227b1f92ecb321522fab4bbbd613230b55450abd6ace023631d0a4f357a780d65c5638bfe

Depends on D5869

This is a backport of Core PR15531

Test Plan
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15288
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10447
Build 18714: Default Diff Build & Tests
Build 18713: arc lint + arc unit

Event Timeline

majcosta created this revision.Apr 28 2020, 08:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 28 2020, 08:43
teamcity edited the summary of this revision. (Show Details)Apr 28 2020, 08:43

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 28 2020, 08:43

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 28 2020, 08:53

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10447: Diff 19194.Apr 28 2020, 08:53
majcosta added a child revision: D5871: [backport#10973] Remove use CValidationInterface in wallet code.Apr 28 2020, 10:38
deadalnix accepted this revision.Apr 28 2020, 13:53
This revision is now accepted and ready to land.Apr 28 2020, 13:53
Closed by commit rABCe6069992d766: [backport#15531] Merge #15531: Suggested interfaces::Chain cleanups from #15288 (authored by MarcoFalke <falke.marco@gmail.com>, committed by majcosta). · Explain WhyApr 28 2020, 19:03
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCe6069992d766: [backport#15531] Merge #15531: Suggested interfaces::Chain cleanups from #15288.
majcosta added a commit: rSTAGINGe6069992d766: [backport#15531] Merge #15531: Suggested interfaces::Chain cleanups from #15288.May 5 2020, 19:11

Revision Contents
Changeset List

PathSize
src/
interfaces/
4 lines
29 lines
9 lines

Diff 19194

View Options

src/interfaces/README.md

Loading...
View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...