Page MenuHomePhabricator
Differential D5963

[lint-circular-dependencies] changed expected dep list to establish baseline
ClosedPublic
Actions

Authored by majcosta on May 5 2020, 14:17.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING176f04bbd644: [lint-circular-dependencies] changed expected dep list to establish baseline
rABC176f04bbd644: [lint-circular-dependencies] changed expected dep list to establish baseline
Summary

removed non-existent circular dependencies from list of expected deps in the linter
and added existent ones so that any change going forward gets caught

Depends on D5962

Test Plan
./test/lint/lint-circular-dependencies.sh and see no output

Diff Detail

Repository
rABC Bitcoin ABC
Branch
add_circular_lint
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10590
Build 18990: Default Diff Build & Tests
Build 18989: arc lint + arc unit

Event Timeline

majcosta created this revision.May 5 2020, 14:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2020, 14:17
majcosta requested review of this revision.May 5 2020, 14:17
majcosta edited the summary of this revision. (Show Details)May 5 2020, 14:17
majcosta added a parent revision: D5962: [backport#13695] lint: Add linter for circular dependencies.
teamcity added a comment.May 5 2020, 14:17

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 5 2020, 14:25

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10590: Diff 19436.May 5 2020, 14:25
majcosta added a child revision: D5967: [backport#15638] [build] Move policy settings to new src/policy/settings unit.May 5 2020, 16:04
deadalnix accepted this revision.May 5 2020, 19:06
This revision is now accepted and ready to land.May 5 2020, 19:06
Closed by commit rABC176f04bbd644: [lint-circular-dependencies] changed expected dep list to establish baseline (authored by majcosta). · Explain WhyMay 5 2020, 20:00
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC176f04bbd644: [lint-circular-dependencies] changed expected dep list to establish baseline.
majcosta added a commit: rSTAGING176f04bbd644: [lint-circular-dependencies] changed expected dep list to establish baseline.May 6 2020, 14:35

Revision Contents
Changeset List

PathSize
test/
lint/
20 lines

Diff 19436

View Options

test/lint/lint-circular-dependencies.sh

Loading...