Page MenuHomePhabricator

[tests] Small fixups before deprecating generate
ClosedPublic

Authored by deadalnix on May 5 2020, 19:23.

Details

Summary

In advance of deprecating the generate RPC method, make some small
changes to a small number of inidividual test cases:

  • make memory checking less prescriptive in wallet_basic.py
  • replace calls to generate with generatetoaddress in wallet_keypool.py
  • replace calls to generate with generatetoaddress and fixup label issues in wallet_labels.py
  • replace calls to generate with generatetoaddress in wallet_multiwallet.py

This is a partial backport of Core PR14468 : https://github.com/bitcoin/bitcoin/pull/14468/commits/c269209336dfa7e4258cfe7d5b0a3bc07b0da3b2

I also added a similar fix for abc-parkedchain.py

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14468-1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10596
Build 19002: Default Diff Build & Tests
Build 19001: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta requested changes to this revision.May 6 2020, 08:19
majcosta added a subscriber: majcosta.

I don't see any changes to wallet_basic.py

This revision now requires changes to proceed.May 6 2020, 08:19

The changed code was removed in D5626 .

This revision is now accepted and ready to land.May 6 2020, 13:27