Page MenuHomePhabricator
Differential D5969

[tests] Small fixups before deprecating generate
ClosedPublic
Actions

Authored by deadalnix on May 5 2020, 19:23.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rSTAGING2eea6849e381: [tests] Small fixups before deprecating generate
rABC2eea6849e381: [tests] Small fixups before deprecating generate
Summary

In advance of deprecating the generate RPC method, make some small
changes to a small number of inidividual test cases:

  • make memory checking less prescriptive in wallet_basic.py
  • replace calls to generate with generatetoaddress in wallet_keypool.py
  • replace calls to generate with generatetoaddress and fixup label issues in wallet_labels.py
  • replace calls to generate with generatetoaddress in wallet_multiwallet.py

This is a partial backport of Core PR14468 : https://github.com/bitcoin/bitcoin/pull/14468/commits/c269209336dfa7e4258cfe7d5b0a3bc07b0da3b2

I also added a similar fix for abc-parkedchain.py

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14468-1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10607
Build 19024: Default Diff Build & Tests
Build 19023: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 5 2020, 19:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2020, 19:23
deadalnix requested review of this revision.May 5 2020, 19:23
teamcity edited the summary of this revision. (Show Details)May 5 2020, 19:23

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 5 2020, 19:23

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 5 2020, 19:32

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10596: Diff 19701.May 5 2020, 19:32
deadalnix added a child revision: D5970: [tests] Add generate method to TestNode.May 5 2020, 23:49
majcosta requested changes to this revision.May 6 2020, 08:19
majcosta added a subscriber: majcosta.

I don't see any changes to wallet_basic.py

This revision now requires changes to proceed.May 6 2020, 08:19
deadalnix requested review of this revision.May 6 2020, 13:03

The changed code was removed in D5626 .

deadalnix updated this revision to Diff 19721.May 6 2020, 13:08

rebase

teamcity added a comment.May 6 2020, 13:13

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta accepted this revision as: majcosta.May 6 2020, 13:13
teamcity added a comment.May 6 2020, 13:25

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10607: Diff 19721.May 6 2020, 13:25
majcosta accepted this revision.May 6 2020, 13:27
This revision is now accepted and ready to land.May 6 2020, 13:27
Closed by commit rABC2eea6849e381: [tests] Small fixups before deprecating generate (authored by John Newbery <john@johnnewbery.com>, committed by deadalnix). · Explain WhyMay 6 2020, 13:47
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC2eea6849e381: [tests] Small fixups before deprecating generate.
deadalnix added a commit: rSTAGING2eea6849e381: [tests] Small fixups before deprecating generate.May 6 2020, 14:35

Revision Contents
Changeset List

PathSize
test/
functional/
16 lines
9 lines
15 lines
8 lines

Diff 19721

View Options

test/functional/abc-parkedchain.py

Loading...
View Options

test/functional/wallet_keypool.py

Loading...
View Options

test/functional/wallet_labels.py

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...