[backport#15638][build] Move several units into common libraries
ClosedPublic
Actions

Authored by majcosta on May 7 2020, 12:34.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING7dce6a570d68: [backport#15638][build] Move several units into common libraries
rABC7dce6a570d68: [backport#15638][build] Move several units into common libraries

Summary

Moves the following units into libbitcoin_util or libbitcoin_common
since they are required by multiple libraries:

bloom
interfaces/handler
merkleblock
outputtype

https://github.com/bitcoin/bitcoin/pull/15638/commits/99517866b62c261f990e1f897502855afc12f2a7

Depends on D5983

This is a partial backport of Core PR15638

Test Plan

ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr15638

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10634
Build 19075: Default Diff Build & Tests
Build 19074: arc lint + arc unit

Event Timeline

majcosta created this revision.May 7 2020, 12:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2020, 12:34

majcosta requested review of this revision.May 7 2020, 12:34

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10634: Diff 19785.May 7 2020, 12:44

deadalnix accepted this revision.May 7 2020, 14:27

This revision is now accepted and ready to land.May 7 2020, 14:27

Closed by commit rABC7dce6a570d68: [backport#15638][build] Move several units into common libraries (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyMay 7 2020, 14:30

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC7dce6a570d68: [backport#15638][build] Move several units into common libraries.

majcosta added a commit: rSTAGING7dce6a570d68: [backport#15638][build] Move several units into common libraries.May 7 2020, 14:35

majcosta added a child revision: D5997: [backport#15638] [build] Add several util units.May 7 2020, 17:40

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

8 lines

Makefile.am

8 lines

Diff 19785

View Options

src/CMakeLists.txt