Page MenuHomePhabricator
Differential D602

Add several symbol in the whitelist for exported symbols.
ClosedPublic
Actions

Authored by deadalnix on Oct 14 2017, 13:57.

Details

Reviewers
freetrader
Mengerian
Group Reviewers
Restricted Project
Commits
rSTAGINGacb6c6d6d4f2: Add several symbol in the whitelist for exported symbols.
rABCacb6c6d6d4f2: Add several symbol in the whitelist for exported symbols.
Summary

As far as I can tell, they shouldn't be exported teh way they are, but end up being on recent ubuntu/debian . While this great mystery is figured out, add them to the whitelist.

Test Plan

Do gitian build and ensure the symbol test phase checks out.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
extrasym
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixcontrib/devtools/symbol-check.py:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 989
Build 989: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 14 2017, 13:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 14 2017, 13:57
Harbormaster completed remote builds in B989: Diff 1553.Oct 14 2017, 13:57
Mengerian accepted this revision.Oct 15 2017, 18:28
This revision is now accepted and ready to land.Oct 15 2017, 18:28
Closed by commit rABCacb6c6d6d4f2: Add several symbol in the whitelist for exported symbols. (authored by deadalnix, committed by deadalnix). · Explain WhyOct 15 2017, 18:30
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
contrib/
devtools/
5 lines

Diff 1553

View Options

contrib/devtools/symbol-check.py

Loading...