Page MenuHomePhabricator
Differential D605

Convert format strings using %u for bools to use %d instead
ClosedPublic
Actions

Authored by Mengerian on Oct 15 2017, 04:33.

Details

Reviewers
CCulianu
freetrader
deadalnix
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING54d3dc8986f4: Convert format strings using %u for bools to use %d instead
rABC54d3dc8986f4: Convert format strings using %u for bools to use %d instead
Summary

Tackling a low-priority ticket to start getting familiar with the code base: https://reviews.bitcoinabc.org/T90

Test Plan

Does this change need test changes? It seems minor enough to not bother, I think...

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jasonbcox created this revision.Oct 15 2017, 04:33
Owners added a reviewer: Restricted Owners Package.Oct 15 2017, 04:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2017, 04:33
deadalnix added a subscriber: deadalnix.Oct 15 2017, 18:12

Why would bool be signed rather than unsigned ?

deadalnix accepted this revision.Oct 15 2017, 18:19

Looked at the task, I see. LGTM.

This revision is now accepted and ready to land.Oct 15 2017, 18:19
Mengerian commandeered this revision.Oct 17 2017, 00:21
Mengerian added a reviewer: jasonbcox.
Closed by commit rABC54d3dc8986f4: Convert format strings using %u for bools to use %d instead (authored by Mengerian, committed by Mengerian). · Explain WhyOct 17 2017, 00:22
This revision was automatically updated to reflect the committed changes.
freetrader mentioned this in T90: Convert format strings using %u for bools to use %d instead.Oct 30 2017, 18:13

Revision Contents
Changeset List

PathSize
src/
44 lines
qt/
6 lines
wallet/
14 lines

Diff 1557

View Options

src/init.cpp

Loading...
View Options

src/qt/utilitydialog.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...