Page MenuHomePhabricator
Differential D668

Do not connect to peers that do not use the cash magic anymore.
ClosedPublic
Actions

Authored by deadalnix on Nov 13 2017, 15:25.

Details

Reviewers
schancel
freetrader
Mengerian
dagurval
Group Reviewers
Restricted Project
Commits
rSTAGINGee128b3dd0dc: Do not connect to peers that do not use the cash magic anymore.
rABCee128b3dd0dc: Do not connect to peers that do not use the cash magic anymore.
Summary

All major implemention now are compatible with the cash magic. It does make sense to start to enforce its use rather than just accepting it.

Test Plan
make check
../qa/pull-tester/rpc-tests.py

Run a node.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nooldmagic
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1142
Build 1142: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 13 2017, 15:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 13 2017, 15:25
schancel added inline comments.Nov 13 2017, 18:48
doc/release-notes.md
7 ↗(On Diff #1717)

Doing release notes like this is going to be a pain as we scale up. Merge conflicts and reorderings will happen.

src/rpc/net.cpp
199 ↗(On Diff #1717)

Why is this part of the node statistics?

deadalnix updated this revision to Diff 1775.Nov 16 2017, 00:30

Rebase

Harbormaster completed remote builds in B1140: Diff 1775.Nov 16 2017, 00:30
deadalnix updated this revision to Diff 1778.Nov 16 2017, 00:38

Rebase

Harbormaster completed remote builds in B1142: Diff 1778.Nov 16 2017, 00:38
deadalnix updated this revision to Diff 1785.Nov 16 2017, 01:29

Rebase

dagurval accepted this revision.Nov 16 2017, 12:46
This revision is now accepted and ready to land.Nov 16 2017, 12:46
Mengerian accepted this revision.Nov 16 2017, 16:43
Closed by commit rABCee128b3dd0dc: Do not connect to peers that do not use the cash magic anymore. (authored by deadalnix). · Explain WhyNov 16 2017, 22:33
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
8 lines
8 lines
15 lines
rpc/
1 line

Diff 1778

View Options

doc/release-notes.md

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...