Page MenuHomePhabricator
Differential D7018

[backport#15588 2/3] Log the actual wallet file version
ClosedPublic
Actions

Authored by majcosta on Jul 23 2020, 03:51.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf92bf72d3825: [backport#15588 2/3] Log the actual wallet file version
Summary

The actual wallet file version is the minversion record, not the
version record.

https://github.com/bitcoin/bitcoin/pull/15588/commits/b3d4f6c9619142948ab3d53551b4f3c0d7d73bde

Depends on D7017

Partial backport of Core PR15588

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Jul 23 2020, 03:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 23 2020, 03:51
majcosta requested review of this revision.Jul 23 2020, 03:51
majcosta added a child revision: D7019: [backport#15588 3/3] Remove ReadVersion and WriteVersion.Jul 23 2020, 03:59
Harbormaster completed remote builds in B12121: Diff 22445.Jul 23 2020, 04:15
Fabien accepted this revision.Jul 23 2020, 08:49
This revision is now accepted and ready to land.Jul 23 2020, 08:49
Closed by commit rABCf92bf72d3825: [backport#15588 2/3] Log the actual wallet file version (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyJul 23 2020, 15:43
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCf92bf72d3825: [backport#15588 2/3] Log the actual wallet file version.
teamcity edited the summary of this revision. (Show Details)Jul 27 2020, 22:05

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Revision Contents
Changeset List

PathSize
src/
wallet/
4 lines

Diff 22471

View Options

src/wallet/walletdb.cpp

Loading...