Anotate methods as override when apropriate
ClosedPublic
Actions

Authored by deadalnix on Dec 6 2017, 16:47.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGf700ba92db8c: Anotate methods as override when apropriate
rABCf700ba92db8c: Anotate methods as override when apropriate

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

addoverride

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1265
Build 1265: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 6 2017, 16:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 6 2017, 16:47

schancel accepted this revision.Dec 6 2017, 16:57

This revision is now accepted and ready to land.Dec 6 2017, 16:57

Closed by commit rABCf700ba92db8c: Anotate methods as override when apropriate (authored by deadalnix). · Explain WhyDec 6 2017, 17:48

This revision was automatically updated to reflect the committed changes.

Fabien mentioned this in D2408: CKeystore/CCrypter: move relevant implementation out of the header.Jan 24 2019, 14:36

nakihito mentioned this in D3620: Merge #10581: Simplify return values of GetCoin/HaveCoin(InCache).Jul 9 2019, 21:09

Revision Contents
Changeset List

Path

Size

src/

9 lines

9 lines

12 lines

2 lines

24 lines

12 lines

qt/

bitcoinaddressvalidator.h

4 lines

bitcoinamountfield.cpp

21 lines

bitcoinunits.h

4 lines

rpc/

mining.cpp

2 lines

script/

6 lines

2 lines

8 lines

2 lines

support/

lockedpool.cpp

12 lines

test/

2 lines

6 lines

8 lines

4 lines

versionbits_tests.cpp

12 lines

12 lines

4 lines

18 lines

12 lines

10 lines

wallet/

crypter.h

20 lines

wallet.h

6 lines

wallet.cpp

4 lines

zmq/

zmqnotificationinterface.h

6 lines

zmqpublishnotifier.h

12 lines

Diff 1964

View Options

src/coins.h

View Options

src/httprpc.cpp

View Options

src/httpserver.cpp

View Options

src/init.cpp

View Options

src/keystore.h

View Options

src/net_processing.h

View Options

src/qt/bitcoinaddressvalidator.h

View Options

src/qt/bitcoinamountfield.cpp

View Options

src/qt/bitcoinunits.h

View Options

src/rpc/mining.cpp

View Options

src/script/interpreter.h

View Options

src/script/sigcache.h

View Options

src/script/sign.h

View Options

src/script/sign.cpp

View Options

src/support/lockedpool.cpp

View Options

src/test/addrman_tests.cpp

View Options

src/test/allocator_tests.cpp

View Options

src/test/coins_tests.cpp

View Options

src/test/net_tests.cpp

View Options

src/test/versionbits_tests.cpp

View Options

src/txdb.h

View Options

src/txdb.cpp

View Options

src/txmempool.h

View Options

src/validation.cpp

View Options

src/versionbits.cpp

View Options

src/wallet/crypter.h

View Options

src/wallet/wallet.h

View Options

src/wallet/wallet.cpp

View Options

src/zmq/zmqnotificationinterface.h

View Options

src/zmq/zmqpublishnotifier.h

Anotate methods as override when apropriateClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1964

src/coins.h

src/httprpc.cpp

src/httpserver.cpp

src/init.cpp

src/keystore.h

src/net_processing.h

src/qt/bitcoinaddressvalidator.h

src/qt/bitcoinamountfield.cpp

src/qt/bitcoinunits.h

src/rpc/mining.cpp

src/script/interpreter.h

src/script/sigcache.h

src/script/sign.h

src/script/sign.cpp

src/support/lockedpool.cpp

src/test/addrman_tests.cpp

src/test/allocator_tests.cpp

src/test/coins_tests.cpp

src/test/net_tests.cpp

src/test/versionbits_tests.cpp

src/txdb.h

src/txdb.cpp

src/txmempool.h

src/validation.cpp

src/versionbits.cpp

src/wallet/crypter.h

src/wallet/wallet.h

src/wallet/wallet.cpp

src/zmq/zmqnotificationinterface.h

src/zmq/zmqpublishnotifier.h

Anotate methods as override when apropriate
ClosedPublic
Actions

Revision Contents
Changeset List