Differential D7864

refactor: Add interfaces::FoundBlock class to selectively return block data
ClosedPublic
Actions

Authored by deadalnix on Oct 10 2020, 23:11.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCc63adee0dd76: refactor: Add interfaces::FoundBlock class to selectively return block data

Summary

FoundBlock class allows interfaces::Chain::findBlock to return more block
information without having lots of optional output parameters. FoundBlock class
is also used by other chain methods in upcoming commits.

There is mostly no change in behavior. Only exception is
CWallet::RescanFromTime now throwing NonFatalCheckError instead of
std::logic_error.

This is part [1/12] of Core PR17954 : https://github.com/bitcoin/bitcoin/pull/17954/commits/bf30cd4922ea62577d7bf63f5029e8be62665d45

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr17954-1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13335
Build 26709: Build Diff	build-clang-tidy · build-without-wallet · lint-circular-dependencies · build-clang · build-diff
Build 26708: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 10 2020, 23:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2020, 23:11

deadalnix requested review of this revision.Oct 10 2020, 23:11

teamcity edited the summary of this revision. (Show Details)Oct 10 2020, 23:12

deadalnix added a child revision: D7865: wallet: Avoid use of Chain::Lock in tryGetTxStatus and tryGetBalances.Oct 10 2020, 23:16

Harbormaster completed remote builds in B13335: Diff 24512.Oct 10 2020, 23:23

Fabien accepted this revision.Oct 11 2020, 10:01

This revision is now accepted and ready to land.Oct 11 2020, 10:01

Closed by commit rABCc63adee0dd76: refactor: Add interfaces::FoundBlock class to selectively return block data (authored by Russell Yanofsky <russ@yanofsky.org>, committed by deadalnix). · Explain WhyOct 11 2020, 12:19

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCc63adee0dd76: refactor: Add interfaces::FoundBlock class to selectively return block data.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

47 lines

55 lines

4 lines

test/

1 line

interfaces_tests.cpp

53 lines

wallet/

10 lines

18 lines

Diff 24512

src/interfaces/chain.h

Loading...

src/interfaces/chain.cpp

Loading...

src/sync.h

Loading...

src/test/CMakeLists.txt

Loading...

src/test/interfaces_tests.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...

src/wallet/wallet.cpp

Loading...