Differential D7865

wallet: Avoid use of Chain::Lock in tryGetTxStatus and tryGetBalances
ClosedPublic
Actions

Authored by deadalnix on Oct 10 2020, 23:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1223cd4064f5: wallet: Avoid use of Chain::Lock in tryGetTxStatus and tryGetBalances

Summary

This is a step toward removing the Chain::Lock class and reducing cs_main
locking.

It also helps ensure the GUI display stays up to date in the case where the
node chain height runs ahead of wallet last block processed height.

This is part [2/12] of Core PR17954 : https://github.com/bitcoin/bitcoin/pull/17954/commits/f6da44ccce4cfff53433e665305a6fe0a01364e4

Depends on D7864

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr17954-2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13336
Build 26711: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang
Build 26710: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 10 2020, 23:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2020, 23:16

deadalnix requested review of this revision.Oct 10 2020, 23:16

teamcity edited the summary of this revision. (Show Details)Oct 10 2020, 23:16

deadalnix edited the summary of this revision. (Show Details)Oct 10 2020, 23:17

deadalnix added a child revision: D7866: wallet refactor: Avoid use of Chain::Lock in qt wallettests.Oct 10 2020, 23:20

Harbormaster completed remote builds in B13336: Diff 24513.Oct 10 2020, 23:30

Fabien accepted this revision.Oct 11 2020, 10:06

This revision is now accepted and ready to land.Oct 11 2020, 10:06

Closed by commit rABC1223cd4064f5: wallet: Avoid use of Chain::Lock in tryGetTxStatus and tryGetBalances (authored by Russell Yanofsky <russ@yanofsky.org>, committed by deadalnix). · Explain WhyOct 11 2020, 12:21

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC1223cd4064f5: wallet: Avoid use of Chain::Lock in tryGetTxStatus and tryGetBalances.

Revision Contents
Changeset List

Path

Size

src/

interfaces/

wallet.cpp

20 lines

wallet/

wallet.h

5 lines

Diff 24513

View Options

src/interfaces/wallet.cpp