Differential D8102

Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyMan
ClosedPublic
Actions

Authored by deadalnix on Oct 24 2020, 22:03.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC67435e511aa3: Move direct calls to MessageSign into new SignMessage functions in CWallet and…

Summary

Instead of getting a SigningProvider and then going to MessageSign,
have ScriptPubKeyMan handle the message signing internally.

Backport of Core PR18115 part [7/9] : https://github.com/bitcoin/bitcoin/pull/18115/commits/6a9c429084b40356aa36aa67992da35f61c2f6a2

Depends on D8101 and D8098

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr18115-7

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13654
Build 27334: Build Diff	build-without-wallet · build-clang-tidy · lint-circular-dependencies · build-clang · build-debug · build-diff
Build 27333: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 24 2020, 22:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 24 2020, 22:03

deadalnix requested review of this revision.Oct 24 2020, 22:03

teamcity edited the summary of this revision. (Show Details)Oct 24 2020, 22:03

Harbormaster completed remote builds in B13654: Diff 25058.Oct 24 2020, 22:11

majcosta accepted this revision.Oct 25 2020, 00:18

This revision is now accepted and ready to land.Oct 25 2020, 00:18

Closed by commit rABC67435e511aa3: Move direct calls to MessageSign into new SignMessage functions in CWallet and… (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyOct 25 2020, 15:17

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC67435e511aa3: Move direct calls to MessageSign into new SignMessage functions in CWallet and….

deadalnix added a child revision: D8114: Replace GetSigningProvider with GetSolvingProvider.Oct 25 2020, 15:29

Revision Contents
Changeset List

Path

Size

src/

interfaces/

wallet.h

6 lines

wallet.cpp

5 lines

qt/

signverifymessagedialog.cpp

30 lines

util/

message.h

8 lines

message.cpp

13 lines

wallet/

22 lines

9 lines

15 lines

3 lines

13 lines

Diff 25058

View Options

src/interfaces/wallet.h

View Options

src/interfaces/wallet.cpp

View Options

src/qt/signverifymessagedialog.cpp

View Options

src/util/message.h

View Options

src/util/message.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/scriptpubkeyman.h

View Options

src/wallet/scriptpubkeyman.cpp

View Options

src/wallet/wallet.h

View Options

Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyManClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25058

src/interfaces/wallet.h

src/interfaces/wallet.cpp

src/qt/signverifymessagedialog.cpp

src/util/message.h

src/util/message.cpp

src/wallet/rpcwallet.cpp

src/wallet/scriptpubkeyman.h

src/wallet/scriptpubkeyman.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyMan
ClosedPublic
Actions

Revision Contents
Changeset List