Differential D8650

refactor: Use AbortError in FatalError
ClosedPublic
Actions

Authored by Fabien on Dec 10 2020, 21:01.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC978bd5b48891: refactor: Use AbortError in FatalError

Summary

FatalError has been copied from AbortNode, so the two should use the
same style to avoid confusion.

Follow-up to #18927

Backport of core PR19295, PR19309 and PR19331.
PR19295 is the original intent
PR19309 is a hacky bug fix
PR19331 reverts PR19309 and fixes PR19295.

In the end the relevant commits are:
https://github.com/bitcoin/bitcoin/pull/19295/commits/fa02b473132932c200be1750d1a5b1de14ea2383
https://github.com/bitcoin/bitcoin/pull/19331/commits/fac96e6450d595fe67168cb7afa7692da6cc9973
https://github.com/bitcoin/bitcoin/pull/19331/commits/fa72ca6a9d90d66012765b0043fd819698b94ba8
https://github.com/bitcoin/bitcoin/pull/19331/commits/cccc2784a3bb10fa8e43be7e68207cafb12bd915

Depends on D8649.

Test Plan

With debug:

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19295

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14376
Build 28727: Build Diff	build-diff · build-debug · lint-circular-dependencies · build-clang-tidy · build-clang · build-without-wallet
Build 28726: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 10 2020, 21:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2020, 21:02

Fabien requested review of this revision.Dec 10 2020, 21:02

teamcity edited the summary of this revision. (Show Details)Dec 10 2020, 21:02

Harbormaster completed remote builds in B14376: Diff 26314.Dec 10 2020, 21:15

Fabien added a child revision: D8651: refactor: Error message bilingual_str consistency.Dec 10 2020, 22:05

jasonbcox accepted this revision.Dec 11 2020, 01:32

This revision is now accepted and ready to land.Dec 11 2020, 01:32

Closed by commit rABC978bd5b48891: refactor: Use AbortError in FatalError (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyDec 11 2020, 07:37

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC978bd5b48891: refactor: Use AbortError in FatalError.

Revision Contents
Changeset List

Path

Size

src/

2 lines

2 lines

2 lines

2 lines

2 lines

index/

base.cpp

7 lines

txindex.cpp

2 lines

init.cpp

2 lines

interfaces/

2 lines

2 lines

2 lines

2 lines

2 lines

	node/

ui_interface.h

10 lines

ui_interface.cpp

2 lines

noui.cpp

30 lines

qt/

1 line

2 lines

2 lines

2 lines

1 line

2 lines

2 lines

2 lines

2 lines

2 lines

util/

11 lines

4 lines

wallet/

init.cpp

2 lines

wallet.h

2 lines

Diff 26314

View Options

src/CMakeLists.txt

View Options

src/banman.cpp

View Options

src/bitcoind.cpp

View Options

src/httprpc.cpp

View Options

src/httpserver.cpp

View Options

src/index/base.cpp

View Options

src/index/txindex.cpp

View Options

src/init.cpp

View Options

src/interfaces/chain.cpp

View Options

src/interfaces/node.cpp

View Options

src/interfaces/wallet.h

View Options

src/interfaces/wallet.cpp

View Options

src/net.cpp

View Options

src/node/ui_interface.h

View Options

src/node/ui_interface.cpp

View Options

src/noui.cpp

View Options

src/qt/bitcoin.cpp

View Options

src/qt/bitcoingui.cpp

View Options

src/qt/paymentserver.cpp

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/qt/splashscreen.cpp

View Options

src/qt/transactionview.cpp

View Options

src/qt/walletmodel.cpp

View Options

src/qt/walletview.cpp

View Options

src/timedata.cpp

View Options

src/txdb.cpp

View Options

src/ui_interface.h

View Options

src/ui_interface.cpp

View Options

src/util/ui_change_type.h

View Options

src/validation.cpp

View Options

src/wallet/init.cpp

View Options

refactor: Use AbortError in FatalErrorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26314

src/CMakeLists.txt

src/banman.cpp

src/bitcoind.cpp

src/httprpc.cpp

src/httpserver.cpp

src/index/base.cpp

src/index/txindex.cpp

src/init.cpp

src/interfaces/chain.cpp

src/interfaces/node.cpp

src/interfaces/wallet.h

src/interfaces/wallet.cpp

src/net.cpp

src/node/ui_interface.h

src/node/ui_interface.cpp

src/noui.cpp

src/qt/bitcoin.cpp

src/qt/bitcoingui.cpp

src/qt/paymentserver.cpp

src/qt/sendcoinsdialog.cpp

src/qt/splashscreen.cpp

src/qt/transactionview.cpp

src/qt/walletmodel.cpp

src/qt/walletview.cpp

src/timedata.cpp

src/txdb.cpp

src/ui_interface.h

src/ui_interface.cpp

src/util/ui_change_type.h

src/validation.cpp

src/wallet/init.cpp

src/wallet/wallet.h

refactor: Use AbortError in FatalError
ClosedPublic
Actions

Revision Contents
Changeset List