Page MenuHomePhabricator
Differential D913

CValidationInterface cleanups
ClosedPublic
Actions

Authored by deadalnix on Jan 7 2018, 17:37.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGa94948a84fa1: CValidationInterface cleanups
rABCa94948a84fa1: CValidationInterface cleanups
Summary

Backport of core's PR9725 and PR10178.

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
validationrefac
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1551
Build 1551: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 7 2018, 17:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2018, 17:37
deadalnix updated this revision to Diff 2404.Jan 7 2018, 20:10

Rebase on top of D915

Harbormaster completed remote builds in B1549: Diff 2404.Jan 7 2018, 20:10
deadalnix added a parent revision: D915: Remove virtual from function marked override already..Jan 7 2018, 20:10
deadalnix updated this revision to Diff 2406.Jan 7 2018, 20:20

Rebase on top of D916

deadalnix added a parent revision: D916: Use std::make_shared when appropriate..Jan 7 2018, 20:21
schancel accepted this revision.Jan 14 2018, 06:23
This revision is now accepted and ready to land.Jan 14 2018, 06:23
Closed by commit rABCa94948a84fa1: CValidationInterface cleanups (authored by Matt Corallo <git@bluematt.me>, committed by deadalnix). · Explain WhyJan 14 2018, 14:05
This revision was automatically updated to reflect the committed changes.
sdulfari mentioned this in D13114: Fixup unbackported comment in ConnectTip.Feb 8 2023, 23:37
sdulfari mentioned this in rABC2ab8cab908fa: Fixup unbackported comment in ConnectTip.Feb 9 2023, 19:58

Revision Contents
Changeset List

Diff 2406

View Options

src/net_processing.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/validationinterface.h

Loading...
View Options

src/validationinterface.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/zmq/zmqnotificationinterface.h

Loading...
View Options

src/zmq/zmqnotificationinterface.cpp

Loading...