Differential D9551

Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers
ClosedPublic
Actions

Authored by Fabien on May 19 2021, 08:55.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC530648e3d421: Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers

Summary

Maintaining up to 100000 INVs per peer is excessive, as that is far more
than fits in a typical mempool.

Also disable the "overload" penalty for PF_RELAY peers.

Partial backport of core#19988:
https://github.com/bitcoin/bitcoin/pull/19988/commits/de11b0a4eff20da3e3ca52dc90948b5253d329c5

Depends on D9550.

Test Plan

ninja all check-all
./test/functional/test_runner.py p2p_tx_download

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR19988_p5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15758
Build 31417: Build Diff	build-without-wallet · build-clang-tidy · build-debug · lint-circular-dependencies · build-clang · build-diff
Build 31416: arc lint + arc unit

Event Timeline

Fabien created this revision.May 19 2021, 08:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 19 2021, 08:55

Fabien requested review of this revision.May 19 2021, 08:55

teamcity edited the summary of this revision. (Show Details)May 19 2021, 08:55

Fabien added a child revision: D9552: Expedite removal of tx requests that are no longer needed.May 19 2021, 09:02

Harbormaster completed remote builds in B15758: Diff 28534.May 19 2021, 09:08

PiRK accepted this revision.May 19 2021, 14:27

This revision is now accepted and ready to land.May 19 2021, 14:27

Closed by commit rABC530648e3d421: Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers (authored by Pieter Wuille <pieter@wuille.net>, committed by Fabien). · Explain WhyMay 20 2021, 15:14

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC530648e3d421: Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers.

Mengerian added a task: Restricted Maniphest Task.May 21 2021, 16:59

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

10 lines

src/

net_permissions.h

2 lines

net_permissions.cpp

3 lines

net_processing.cpp

18 lines

test/

functional/

p2p_tx_download.py

24 lines

Diff 28534

doc/release-notes.md

Loading...

src/net_permissions.h

Loading...

src/net_permissions.cpp

Loading...

src/net_processing.cpp

Loading...

test/functional/p2p_tx_download.py

Loading...