Page MenuHomePhabricator
Differential D9598

Extract inv saturation check and data request time computation
ClosedPublic
Actions

Authored by Fabien on May 27 2021, 19:01.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCe19bc0f9629c: Extract inv saturation check and data request time computation
Summary

The functions are extracted from the PeerManager::AddTxAnnouncement()
method so they can be reused for proofs announcements as well. They take
the InvRequestTracker as a parameter as well as a structure containing
the inventory specific parameters.

Part of T1611

Test Plan
ninja all check-all
./test/functional/test_runner.py p2p_inv_download

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 27 2021, 19:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 27 2021, 19:02
Fabien requested review of this revision.May 27 2021, 19:02
Fabien edited the summary of this revision. (Show Details)May 27 2021, 19:05
Harbormaster completed remote builds in B15836: Diff 28654.May 27 2021, 19:18
deadalnix requested changes to this revision.May 27 2021, 20:15
deadalnix added a subscriber: deadalnix.

Looks good overall.

src/net_processing.cpp
133 ↗(On Diff #28654)

newline

938 ↗(On Diff #28654)

Breaking news :) newlines are free!

942 ↗(On Diff #28654)

It doesn't seem optimal to use the same permission for both here.

947 ↗(On Diff #28654)

**

This revision now requires changes to proceed.May 27 2021, 20:15
Fabien updated this revision to Diff 28656.May 28 2021, 07:59

Add 3 extra bytes for more pleasure

Harbormaster completed remote builds in B15837: Diff 28656.May 28 2021, 08:13
Fabien updated this revision to Diff 28659.May 28 2021, 11:22

Make the getdata interval part of the structure

Harbormaster completed remote builds in B15840: Diff 28659.May 28 2021, 11:36
Fabien added a child revision: D9582: [avalanche] Answer proof invs with getdata proof requests.May 28 2021, 12:34
deadalnix accepted this revision.May 28 2021, 13:05
This revision is now accepted and ready to land.May 28 2021, 13:05
deadalnix requested changes to this revision.May 28 2021, 13:16

Reviewing patches based on top of this, it is abundantly clear that that hasn't been thought through at all.

This revision now requires changes to proceed.May 28 2021, 13:16
Fabien updated this revision to Diff 28729.Jun 2 2021, 19:09

Add the limit bypass permission flags to the structure so we can use different permission for tx and proofs without adding much to the code

Harbormaster completed remote builds in B15889: Diff 28729.Jun 2 2021, 19:18
deadalnix accepted this revision.Jun 3 2021, 13:51
This revision is now accepted and ready to land.Jun 3 2021, 13:51
Closed by commit rABCe19bc0f9629c: Extract inv saturation check and data request time computation (authored by Fabien). · Explain WhyJun 3 2021, 14:45
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCe19bc0f9629c: Extract inv saturation check and data request time computation.
Mengerian added a task: Restricted Maniphest Task.Jun 3 2021, 18:22

Revision Contents
Changeset List

PathSize
src/
159 lines

Diff 28741

View Options

src/net_processing.cpp

Loading...