Page MenuHomePhabricator

Source the Excessive block size from BlockValidationOptions
ClosedPublic

Authored by deadalnix on Sep 12 2019, 05:55.

Details

Summary

After all, it's a block validation option.

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
BlockValidationOptionsExcessiveBlockSize
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7409
Build 12861: Bitcoin ABC Buildbot (legacy)
Build 12860: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Sep 12 2019, 07:07
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/bench/checkblock.cpp
53

It can be constructed once outside of the loop.

src/validation.h
592

BlockValidationOptions can be passed as const.

611

Dito.

This revision now requires changes to proceed.Sep 12 2019, 07:07
src/validation.h
592

It's immutable by design.

611

dito

This revision is now accepted and ready to land.Sep 12 2019, 07:33