Page MenuHomePhabricator
Differential D4094

Add compile time checking for all cs_main runtime locking assertions
ClosedPublic
Actions

Authored by deadalnix on Sep 16 2019, 14:40.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING0ba7f1945c07: Add compile time checking for all cs_main runtime locking assertions
rABC0ba7f1945c07: Add compile time checking for all cs_main runtime locking assertions
Summary

This turned out to be fairly different from the original due to numerous changes in our codebase.

This is a backport of Core PR13083

Test Plan
ninja all check

Using clang as a compiler

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13083
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7484
Build 13011: Bitcoin ABC Buildbot (legacy)
Build 13010: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 16 2019, 14:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2019, 14:40
teamcity added a comment.Sep 16 2019, 14:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7480: Diff 11345.Sep 16 2019, 14:50
teamcity added a comment.Sep 16 2019, 14:50

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix updated this revision to Diff 11350.Sep 16 2019, 15:36

Extract D4096

teamcity added a comment.Sep 16 2019, 15:36

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 16 2019, 15:36

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7484: Diff 11350.Sep 16 2019, 15:49
teamcity added a comment.Sep 16 2019, 15:49

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien requested changes to this revision.Sep 17 2019, 06:06
Fabien added a subscriber: Fabien.

What backport is it ?

This revision now requires changes to proceed.Sep 17 2019, 06:06
deadalnix requested review of this revision.Sep 17 2019, 10:36
deadalnix edited the summary of this revision. (Show Details)
Fabien accepted this revision.Sep 17 2019, 11:44
Fabien added inline comments.
src/validation.cpp
213

This one is from PR13481

This revision is now accepted and ready to land.Sep 17 2019, 11:44
Closed by commit rABC0ba7f1945c07: Add compile time checking for all cs_main runtime locking assertions (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by deadalnix). · Explain WhySep 17 2019, 12:36
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC0ba7f1945c07: Add compile time checking for all cs_main runtime locking assertions.
deadalnix added a commit: rSTAGING0ba7f1945c07: Add compile time checking for all cs_main runtime locking assertions.Sep 19 2019, 02:24
nakihito mentioned this in D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.Sep 24 2019, 00:45
nakihito mentioned this in D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.Sep 24 2019, 01:27
nakihito mentioned this in D5316: Merge #14023: Remove accounts rpcs.Mar 4 2020, 20:20

Revision Contents
Changeset List

PathSize
src/
interfaces/
11 lines
3 lines
12 lines
test/
3 lines
3 lines
9 lines
94 lines
4 lines
1 line
wallet/
3 lines
9 lines
50 lines
3 lines

Diff 11350

View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/net_processing.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/test/miner_tests.cpp

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/validationinterface.h

Loading...
View Options

src/validationinterface.cpp

Loading...
View Options

src/wallet/finaltx.h

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...