Page MenuHomePhabricator
Differential D4079

debug log number of unknown wallet records on load
ClosedPublic
Actions

Authored by fpelliccioni on Sep 13 2019, 22:29.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGea8cef58c8dc: debug log number of unknown wallet records on load
rABCea8cef58c8dc: debug log number of unknown wallet records on load
Summary

This would have saved me some time during wallet debugging, with minimal logging clutter.

Backport of Bitcoin Core PR12888
https://github.com/bitcoin/bitcoin/pull/12888

Test Plan
  1. make check-all
  2. ./src/bitcoind -regtest
  3. Verify that "Unknown wallet records:" appears in the log file.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-39439e5ab
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7520
Build 13080: Bitcoin ABC Buildbot (legacy)
Build 13079: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Sep 13 2019, 22:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2019, 22:29
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 13 2019, 22:29

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 13 2019, 22:30

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 13 2019, 22:31

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 13 2019, 22:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7455: Diff 11305.Sep 13 2019, 22:44
deadalnix accepted this revision.Sep 14 2019, 07:52
This revision is now accepted and ready to land.Sep 14 2019, 07:52
deadalnix requested changes to this revision.Sep 14 2019, 07:56

While the code looks correct, it doesn't seems that there is a test case for this behavior, and therefore the test plan don't test for anything useful.

This revision now requires changes to proceed.Sep 14 2019, 07:56
deadalnix added a child revision: D4091: Use C++11 default member initializers.Sep 16 2019, 10:12
fpelliccioni edited the test plan for this revision. (Show Details)Sep 20 2019, 13:01
fpelliccioni updated this revision to Diff 13029.Sep 20 2019, 13:03
fpelliccioni edited the test plan for this revision. (Show Details)

Test plan fixed.

teamcity added a comment.Sep 20 2019, 13:13

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 20 2019, 13:32

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7520: Diff 13029.Sep 20 2019, 13:32
deadalnix accepted this revision.Sep 20 2019, 16:15
This revision is now accepted and ready to land.Sep 20 2019, 16:15
Closed by commit rABCea8cef58c8dc: debug log number of unknown wallet records on load (authored by fpelliccioni). · Explain WhySep 20 2019, 18:21
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABCea8cef58c8dc: debug log number of unknown wallet records on load.
fpelliccioni added a commit: rSTAGINGea8cef58c8dc: debug log number of unknown wallet records on load.Sep 27 2019, 22:46

Revision Contents
Changeset List

PathSize
src/
wallet/
11 lines

Diff 13029

View Options

src/wallet/walletdb.cpp

Loading...