Paths

Table of Contentst

Differential D4125

net: move BanMan to its own files
ClosedPublic
Actions

Authored by deadalnix on Sep 21 2019, 11:02.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGf4d2c86a92a8: net: move BanMan to its own files
rABCf4d2c86a92a8: net: move BanMan to its own files

Summary

This is a partial backport of Core PR14605 : https://github.com/bitcoin/bitcoin/pull/14605/commits/af3503d903b1a608cd212e2d74b274103199078c

Depends on D4124

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

movebanman

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7535
Build 13110: Bitcoin ABC Buildbot (legacy)
Build 13109: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 21 2019, 11:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 21 2019, 11:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7535: Diff 13050.Sep 21 2019, 11:13

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix added a child revision: D4126: scripted-diff: batch-rename BanMan members.Sep 21 2019, 11:15

Fabien requested changes to this revision.Sep 22 2019, 11:10

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/CMakeLists.txt
344	Good catch
src/banman.h
36	The layout can be improved
73	`#endif // BITCOIN_BANMAN_H` That would be 1 less fix when the linter gets updated.

This revision now requires changes to proceed.Sep 22 2019, 11:10

deadalnix added inline comments.Sep 22 2019, 11:36

src/banman.h
36	We can keep it that way. It fit our style and will reduce merge problems.

Rebase, fix inlucdes due to D4131 and add comment on the #endif

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien accepted this revision.Sep 22 2019, 12:00

Fabien added inline comments.

src/banman.h
36	Fair enough.

This revision is now accepted and ready to land.Sep 22 2019, 12:00

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7546: Diff 13065.Sep 22 2019, 12:13

Closed by commit rABCf4d2c86a92a8: net: move BanMan to its own files (authored by Cory Fields <cory-nospam-@coryfields.com>, committed by deadalnix). · Explain WhySep 22 2019, 12:35

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCf4d2c86a92a8: net: move BanMan to its own files.

deadalnix added a commit: rSTAGINGf4d2c86a92a8: net: move BanMan to its own files.Sep 27 2019, 22:46

Revision Contents
Changeset List

Path

Size

src/

3 lines

4 lines

73 lines

214 lines

1 line

interfaces/

1 line

1 line

53 lines

214 lines

1 line

rpc/

net.cpp

1 line

test/

denialofservice_tests.cpp

1 line

test_bitcoin.cpp

1 line

test_bitcoin_main.cpp

1 line

Diff 13050

View Options

src/CMakeLists.txt

View Options

src/Makefile.am

View Options

src/banman.h

View Options

src/banman.cpp

View Options

src/init.cpp

View Options

src/interfaces/node.h

View Options

src/interfaces/node.cpp

View Options

src/net.h

View Options

src/net.cpp

View Options

src/net_processing.cpp

View Options

src/rpc/net.cpp

View Options

src/test/denialofservice_tests.cpp

View Options

src/test/test_bitcoin.cpp

View Options

src/test/test_bitcoin_main.cpp

net: move BanMan to its own filesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 13050

src/CMakeLists.txt

src/Makefile.am

src/banman.h

src/banman.cpp

src/init.cpp

src/interfaces/node.h

src/interfaces/node.cpp

src/net.h

src/net.cpp

src/net_processing.cpp

src/rpc/net.cpp

src/test/denialofservice_tests.cpp

src/test/test_bitcoin.cpp

src/test/test_bitcoin_main.cpp

net: move BanMan to its own files
ClosedPublic
Actions

Revision Contents
Changeset List