Page MenuHomePhabricator

net: move BanMan to its own files
ClosedPublic

Authored by deadalnix on Sep 21 2019, 11:02.

Details

Diff Detail

Repository
rABC Bitcoin ABC
Branch
movebanman
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7546
Build 13132: Bitcoin ABC Buildbot (legacy)
Build 13131: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Sep 22 2019, 11:10
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/CMakeLists.txt
344 ↗(On Diff #13050)

Good catch

src/banman.h
36 ↗(On Diff #13050)

The layout can be improved

73 ↗(On Diff #13050)

#endif // BITCOIN_BANMAN_H
That would be 1 less fix when the linter gets updated.

This revision now requires changes to proceed.Sep 22 2019, 11:10
src/banman.h
36 ↗(On Diff #13050)

We can keep it that way. It fit our style and will reduce merge problems.

Rebase, fix inlucdes due to D4131 and add comment on the #endif

Fabien added inline comments.
src/banman.h
36 ↗(On Diff #13050)

Fair enough.

This revision is now accepted and ready to land.Sep 22 2019, 12:00