Page MenuHomePhabricator
Differential D4117

banman: pass the banfile path in
ClosedPublic
Actions

Authored by deadalnix on Sep 20 2019, 15:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING1ca887fa7414: banman: pass the banfile path in
rABC1ca887fa7414: banman: pass the banfile path in
Summary

There's no need to hard-code the path here. Passing it in means that there are
no ordering concerns wrt establishing the datadir.

This is a partial backport of Core PR14605 : https://github.com/bitcoin/bitcoin/pull/14605/commits/2e56702ecedd83c4b7cb8de9de5c437c8c08e645

Depends on D4114

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
banfile
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7544
Build 13128: Bitcoin ABC Buildbot (legacy)
Build 13127: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 20 2019, 15:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 20 2019, 15:55
teamcity added a comment.Sep 20 2019, 15:55

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix edited the summary of this revision. (Show Details)Sep 20 2019, 16:00
deadalnix added a parent revision: D4114: banman: create and split out banman.
teamcity added a comment.Sep 20 2019, 16:06

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7526: Diff 13035.Sep 20 2019, 16:06
deadalnix added a child revision: D4124: banman: pass in default ban time as a parameter.Sep 21 2019, 10:28
Fabien accepted this revision.Sep 22 2019, 10:51
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/addrdb.h
92 ↗(On Diff #13035)

explicit is not really necessary here

This revision is now accepted and ready to land.Sep 22 2019, 10:51
deadalnix updated this revision to Diff 13061.Sep 22 2019, 11:25

Rebase and nits

teamcity added a comment.Sep 22 2019, 11:25

Build Bitcoin-ABC / Diffs / Diff Testing started.

This revision was landed with ongoing or failed builds.Sep 22 2019, 11:26
Closed by commit rABC1ca887fa7414: banman: pass the banfile path in (authored by Cory Fields <cory-nospam-@coryfields.com>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC1ca887fa7414: banman: pass the banfile path in.
teamcity added a comment.Sep 22 2019, 11:26

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 22 2019, 11:26

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 22 2019, 11:26

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix added a commit: rSTAGING1ca887fa7414: banman: pass the banfile path in.Sep 27 2019, 22:46

Revision Contents
Changeset List

PathSize
src/
4 lines
9 lines
3 lines
6 lines
12 lines
test/
9 lines
3 lines

Diff 13061

View Options

src/addrdb.h

Loading...
View Options

src/addrdb.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/test/denialofservice_tests.cpp

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...