Revert change to PreciousBlock() comment made in D1182
ClosedPublic
Actions

Authored by nakihito on Sep 23 2019, 17:41.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGc9da74332c34: Revert change to PreciousBlock() comment made in D1182
rABCc9da74332c34: Revert change to PreciousBlock() comment made in D1182

Summary

Reverts change to commet for PreciousBlock() in validation.h that was
made in D1182. This reduces our code ownership and merge conflicts when
backporting.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

revertpreciousblockcomment

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7554
Build 13148: Bitcoin ABC Buildbot (legacy)
Build 13147: arc lint + arc unit

Event Timeline

nakihito created this revision.Sep 23 2019, 17:41

Owners added a reviewer: Restricted Owners Package.Sep 23 2019, 17:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2019, 17:41

nakihito planned changes to this revision.Sep 23 2019, 17:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

In the spirit of keeping consistent with D4045.

nakihito added a child revision: D4139: Merge #13402: Document validationinterace callback blocking deadlock potential..Sep 23 2019, 17:54

Harbormaster completed remote builds in B7554: Diff 13089.Sep 23 2019, 17:56

Build Bitcoin-ABC / Diffs / Diff Testing passed.

I don't mind this since resolving merge conflicts against these comments is becoming tiresome. Only downside is that we're losing a more valuable explanation of what a "precious" block is, but inspection of the code solves this.

This revision is now accepted and ready to land.Sep 23 2019, 21:47

Closed by commit rABCc9da74332c34: Revert change to PreciousBlock() comment made in D1182 (authored by nakihito). · Explain WhySep 23 2019, 22:17

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCc9da74332c34: Revert change to PreciousBlock() comment made in D1182.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGc9da74332c34: Revert change to PreciousBlock() comment made in D1182.Sep 27 2019, 22:48