Page MenuHomePhabricator
Differential D4136

[CMAKE] Add the check-symbols target
ClosedPublic
Actions

Authored by Fabien on Sep 23 2019, 11:48.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGa7b6fd856433: [CMAKE] Add the check-symbols target
rABCa7b6fd856433: [CMAKE] Add the check-symbols target
Summary

This target runs the symbol-check.py scripts on the executables.
This is the equivalent of the autotools check-symbols rule.

Test Plan

Build the depends subsystem for linux 64, then:

mkdir buildcmake && cd buildcmake
cmake -GNinja .. \
  -DENABLE_GLIBC_BACK_COMPAT=ON \
  -DENABLE_STATIC_LIBSTDCXX=ON \
  -DENABLE_REDUCE_EXPORTS=ON \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake
ninja check-symbols

If should be successful.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_check_symbols
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7567
Build 13174: Bitcoin ABC Buildbot (legacy)
Build 13173: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 23 2019, 11:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 23 2019, 11:48
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 23 2019, 11:48

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 23 2019, 12:00

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7552: Diff 13083.Sep 23 2019, 12:00
Fabien added a child revision: D4137: [CMAKE] Add the check-security target.Sep 23 2019, 13:00
jasonbcox accepted this revision.Sep 23 2019, 23:55
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
CMakeLists.txt
33 ↗(On Diff #13083)

Nit: This comment is looking redundant. Consider removing it.

This revision is now accepted and ready to land.Sep 23 2019, 23:55
Fabien planned changes to this revision.Sep 24 2019, 08:26
Fabien updated this revision to Diff 13107.Sep 24 2019, 09:51

Rebase on top of D4144.
Update comment as per feedback.
Do not check bench or test binaries, that are not intended to be installed.

This revision is now accepted and ready to land.Sep 24 2019, 09:51
teamcity added a comment.Sep 24 2019, 09:52

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 24 2019, 10:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7567: Diff 13107.Sep 24 2019, 10:01
Closed by commit rABCa7b6fd856433: [CMAKE] Add the check-symbols target (authored by Fabien). · Explain WhySep 25 2019, 18:47
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa7b6fd856433: [CMAKE] Add the check-symbols target.
Fabien added a commit: rSTAGINGa7b6fd856433: [CMAKE] Add the check-symbols target.Sep 27 2019, 22:49

Revision Contents
Changeset List

PathSize
3 lines
cmake/
modules/
19 lines
src/
7 lines
qt/
3 lines
seeder/
3 lines

Diff 13107

View Options

CMakeLists.txt

Loading...
View Options

cmake/modules/BinaryTest.cmake

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/qt/CMakeLists.txt

Loading...
View Options

src/seeder/CMakeLists.txt

Loading...