Paths

Table of Contentst

Differential D4172

Moved Misbehaving() overload to header file
AbandonedPublic
Actions

Authored by jasonbcox on Sep 27 2019, 17:22.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Summary

This makes the code cleaner by allowing the Misbehaving() overload to be used outside of net_processing.cpp.

Depends on D4150

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

misbehaving

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7615
Build 13270: Bitcoin ABC Buildbot (legacy)
Build 13269: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Sep 27 2019, 17:22

Herald added a reviewer: deadalnix. · View Herald TranscriptSep 27 2019, 17:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox mentioned this in D4150: Merge #12218: net: Move misbehaving logging to net logging category.Sep 27 2019, 17:24

Harbormaster completed remote builds in B7615: Diff 13182.Sep 27 2019, 17:34

Build Bitcoin-ABC / Diffs / Diff Testing passed.

This seems to me to be gratuitously moving away from core for no good reason. What's the reason?

src/net_processing.h
131	I'm not sure what this combination of qualifier does.

I think you're right.

Revision Contents
Changeset List

Path

Size

src/

net_processing.h

6 lines

net_processing.cpp

6 lines

test/

denialofservice_tests.cpp

14 lines

Diff 13182

View Options

src/net_processing.h

View Options

src/net_processing.cpp

View Options

src/test/denialofservice_tests.cpp

Moved Misbehaving() overload to header fileAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 13182

src/net_processing.h

src/net_processing.cpp

src/test/denialofservice_tests.cpp

Moved Misbehaving() overload to header file
AbandonedPublic
Actions

Revision Contents
Changeset List