[Tests] Cleanup extra instances of create_transaction
ClosedPublic
Actions

Authored by nakihito on Jan 2 2020, 21:48.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGa719d2847528: [Tests] Cleanup extra instances of create_transaction
rABCa719d2847528: [Tests] Cleanup extra instances of create_transaction

Summary

Partial backport of Core PR13669
https://github.com/bitcoin/bitcoin/pull/13669/commits/736f9414246f2a855e7b6fc57c8f903e60530540

Changes to feature_csv_activation.py omitted because they caused the
test to fail the assert in create_transaction() due to divergences in our codebases.
https://github.com/bitcoin/bitcoin/pull/13669/commits/736f9414246f2a855e7b6fc57c8f903e60530540#diff-72d4bdc0bac8c2153666b0a94544af94L50

Depends on D4820

Test Plan

test/functional/test_runner.py abc-mempool-accept-txn abc-mempool-coherence-on-activations abc-minimaldata abc-replay-protection abc-schnorr abc-schnorrmultisig feature_block feature_cltv feature_dersig p2p_invalid_block p2p_invalid_tx p2p_unrequested_blocks

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13669-2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8713
Build 15411: Default Diff Build & Tests
Build 15410: arc lint + arc unit

Event Timeline

nakihito created this revision.Jan 2 2020, 21:48

Owners added a reviewer: Restricted Owners Package.Jan 2 2020, 21:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 2 2020, 21:48

nakihito planned changes to this revision.Jan 2 2020, 21:48

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8713: Diff 15118.Jan 2 2020, 22:01

nakihito edited the summary of this revision. (Show Details)Jan 3 2020, 01:04

nakihito added a parent revision: D4820: [Tests] Rename create_tx and move to blocktools.py.

nakihito added a child revision: D4822: [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object.

nakihito requested review of this revision.Jan 3 2020, 20:19

nakihito edited the summary of this revision. (Show Details)

nakihito added inline comments.

test/functional/feature_cltv.py
93	This goes by a different name in our codebase, but is equivalent to Core's `create_transaction()` here: https://github.com/bitcoin/bitcoin/pull/13669/commits/736f9414246f2a855e7b6fc57c8f903e60530540#diff-50b4837bfc0343f848b10959ad7c5220L61