Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING2bdc64fc4160: [backport#15288] Remove uses of CheckFinalTx in wallet code
rABC2bdc64fc4160: [backport#15288] Remove uses of CheckFinalTx in wallet code

Summary

80f52a2267f44a9cae4440615df3ff989be1579c This commit does not change behavior. (Russell Yanofsky)

This is a follow up to D5804 and a partial backport of Core PR15288

Test Plan

cmake .. -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug -DBUILD_BITCOIN_WALLET=OFF
ninja check check-functional
cmake .. -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10372
Build 18565: Default Diff Build & Tests
Build 18564: arc lint + arc unit

Event Timeline

majcosta created this revision.Apr 23 2020, 16:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 23 2020, 16:48

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta planned changes to this revision.Apr 23 2020, 16:52

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10365: Diff 19059.Apr 23 2020, 16:58

majcosta requested review of this revision.Apr 23 2020, 17:01

majcosta edited the summary of this revision. (Show Details)Apr 23 2020, 17:15

majcosta added a child revision: D5819: [backport#15288] Remove use of IsRBFOptIn in wallet code.Apr 23 2020, 20:08

deadalnix requested changes to this revision.Apr 23 2020, 22:34

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/interfaces/chain.cpp
139 ↗	(On Diff #19059)	Why flags?
src/interfaces/chain.h
9 ↗	(On Diff #19059)	You can forward declare instead of adding includes, because you only pass by ref.