Page MenuHomePhabricator
Differential D5831

[backport#15288] Remove use of CalculateMemPoolAncestors in wallet code
ClosedPublic
Actions

Authored by majcosta on Apr 24 2020, 19:09.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGbf1fc2dd8a7f: [backport#15288] Remove use of CalculateMemPoolAncestors in wallet code
rABCbf1fc2dd8a7f: [backport#15288] Remove use of CalculateMemPoolAncestors in wallet code
Summary

1fb0a4a04e9cda19ed5ad04694a39c83c91b6072 This commit does not change behavior. (Russell Yanofski)

Depends on D5826

This is a partial backport of Core PR15288

Test Plan
cmake .. -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15288
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10386
Build 18593: Default Diff Build & Tests
Build 18592: arc lint + arc unit

Event Timeline

majcosta created this revision.Apr 24 2020, 19:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 24 2020, 19:09
teamcity added a comment.Apr 24 2020, 19:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster failed remote builds in B10386: Diff 19093!Apr 24 2020, 19:10
teamcity added a comment.Apr 24 2020, 19:10
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Counting objects:  82% (19/23)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Counting objects:  86% (20/23)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Counting objects:  91% (21/23)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Counting objects:  95% (22/23)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Counting objects: 100% (23/23)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Counting objects: 100% (23/23), done.        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects:   6% (1/16)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects:  12% (2/16)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects:  18% (3/16)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects:  25% (4/16)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects:  31% (5/16)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects:  37% (6/16)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects:  43% (7/16)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects:  50% (8/16)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects:  56% (9/16)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects:  62% (10/16)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects:  68% (11/16)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects:  75% (12/16)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects:  81% (13/16)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects:  87% (14/16)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects:  93% (15/16)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects: 100% (16/16)        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Compressing objects: 100% (16/16), done.        
[19:10:22]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] remote: Total 16 (delta 15), reused 0 (delta 0), pack-reused 0        
[19:10:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093] From ssh://reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging
[19:10:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093]  * [new tag]             phabricator/diff/19093 -> phabricator/diff/19093
[19:10:23]i:				 [/usr/bin/git -c credential.helper= fetch --progress origin +refs/tags/phabricator/diff/19093:refs/tags/phabricator/diff/19093]  * [new tag]             phabricator/base/19093 -> phabricator/base/19093
[19:10:23] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git log -n1 --pretty=format:%H%x20%s ca644d0f20f9a033a0db1893f6279b50b40dacbe --
[19:10:23] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git pack-refs --all
[19:10:23] :		 [VCS Root: Bitcoin ABC Staging] Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)
[19:10:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] The .git directory is missing in '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc'. Running 'git init'...
[19:10:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git init
[19:10:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config lfs.storage /home/teamcity/buildAgent/system/git/git-48AA3180.git/lfs
[19:10:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config core.sparseCheckout true
[19:10:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config http.sslCAInfo
[19:10:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref
[19:10:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/19093
[19:10:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git log -n1 --pretty=format:%H%x20%s ca644d0f20f9a033a0db1893f6279b50b40dacbe --
[19:10:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git -c credential.helper= checkout -q -f phabricator/diff/19093
[19:10:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/19093
[19:10:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] Cleaning Bitcoin ABC Staging in /home/teamcity/buildAgent/work/jailed-build/bitcoin-abc the file set ALL_UNTRACKED
[19:10:23] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git clean -f -d -x
[19:10:23] : Build preparation done
[19:10:23]E: Step 1/2: Command Line (7s)
[19:10:23] :	 [Step 1/2] Ant JUnit report watcher
[19:10:23] :		 [Ant JUnit report watcher] Watching paths:
[19:10:23] :		 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[19:10:23] :		 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[19:10:23] :	 [Step 1/2] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script9169864347692040227
[19:10:23] :	 [Step 1/2] in directory: /home/teamcity/buildAgent/work/jailed-build
[19:10:23] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[19:10:23] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[19:10:23] :	 [Step 1/2] Building base image for: ca644d0f2...
[19:10:23] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[19:10:23] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[19:10:23] :	 [Step 1/2] Tag name: abc-base-image-ca644d0f2
[19:10:30]W:	 [Step 1/2] /bin/bash: -c: line 0: syntax error near unexpected token `;'
[19:10:30]W:	 [Step 1/2] /bin/bash: -c: line 0: `results() { set +e ;   cp -r /tmp/sanitizer_logs /results ;   cp -r -T /work/build /results ;   cp /work/ibd/debug.log /results ;   chown -R 1001 /work ;   chown -R 1001 /results ; } ; trap "results" EXIT ;  ; # depends cache ; export BASE_CACHE=/root/abc-depends/cache ; export SOURCES_PATH=/root/abc-depends/sources ; mkdir -p "" "" ;  ; ./contrib/teamcity/build-configurations.sh'
[19:10:30]W:	 [Step 1/2] Process exited with code 1
[19:10:30]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)
majcosta edited the summary of this revision. (Show Details)Apr 24 2020, 19:18
majcosta added a parent revision: D5826: [backport#15288] Remove use of GetTransactionAncestry in wallet code.
teamcity added a comment.Apr 24 2020, 19:57

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 24 2020, 19:57
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[19:57:38]i:	 [Collecting changes in 3 VCS roots] Will collect changes for 'ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc.git' starting from revision b9b2f8fb901be8a2b6a411919100bc2aa8f7f1b4
[19:57:38]i:	 [Collecting changes in 3 VCS roots] Detecting changes in VCS root 'Bitcoin ABC Staging' (used in 'Bitcoin ABC Diff Base Image (defunct)', 'Bitcoin-ABC Gitian Diff Testing' and 5 other configurations)
[19:57:38]i:	 [Collecting changes in 3 VCS roots] Will collect changes for 'Bitcoin ABC Staging' starting from revision 1678967611ccb25b630c4d8b93d406d7d20af191
[19:57:38] :	 [Collecting changes in 3 VCS roots] Compute revision for 'Bitcoin ABC Staging'
[19:57:38] :		 [Compute revision for 'Bitcoin ABC Staging'] Upper limit revision: ca644d0f20f9a033a0db1893f6279b50b40dacbe
[19:57:38]i:		 [Compute revision for 'Bitcoin ABC Staging'] MaxModId = 21278
[19:57:38] :		 [Compute revision for 'Bitcoin ABC Staging'] Latest commit attached to build configuration: ca644d0f20f9a033a0db1893f6279b50b40dacbe
[19:57:38] :		 [Compute revision for 'Bitcoin ABC Staging'] Computed revision: ca644d0f20f9a033a0db1893f6279b50b40dacbe
[19:57:43] : The build is removed from the queue to be prepared for the start
[19:57:44] : Starting the build on the agent highperf1
[19:57:44]i: Agent time zone: Etc/UTC
[19:57:44]i: Agent is running under JRE: 1.8.0_232-b09
[19:57:45] : Clearing temporary directory: /home/teamcity/buildAgent/temp/buildTmp
[19:57:45] : Publishing internal artifacts (2s)
[19:57:47] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[19:57:47] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[19:57:45] : Clean build enabled: removing old files from /home/teamcity/buildAgent/work/jailed-build
[19:57:45] : Checkout directory: /home/teamcity/buildAgent/work/jailed-build
[19:57:45] : Updating sources: agent side checkout (2s)
[19:57:45] :	 [Updating sources] VCS Root: Bitcoin ABC Staging (2s)
[19:57:45] :		 [VCS Root: Bitcoin ABC Staging] checkout rules: =>bitcoin-abc; revision: ca644d0f20f9a033a0db1893f6279b50b40dacbe
[19:57:45] :		 [VCS Root: Bitcoin ABC Staging] Git version: 2.20.1.0
[19:57:45] :		 [VCS Root: Bitcoin ABC Staging] Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git) (1s)
[19:57:45] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git config http.sslCAInfo
[19:57:45] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref
[19:57:45] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git -c credential.helper= ls-remote origin
[19:57:46] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref refs/tags/phabricator/diff/19093
[19:57:46] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref refs/tags/phabricator/diff/19093
[19:57:46] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git pack-refs --all
[19:57:46] :		 [VCS Root: Bitcoin ABC Staging] Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)
[19:57:46] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] The .git directory is missing in '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc'. Running 'git init'...
[19:57:46] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git init
[19:57:46] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config lfs.storage /home/teamcity/buildAgent/system/git/git-48AA3180.git/lfs
[19:57:46] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config core.sparseCheckout true
[19:57:46] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config http.sslCAInfo
[19:57:46] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref
[19:57:46] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/19093
[19:57:46] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git log -n1 --pretty=format:%H%x20%s ca644d0f20f9a033a0db1893f6279b50b40dacbe --
[19:57:47] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git -c credential.helper= checkout -q -f phabricator/diff/19093
[19:57:47] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/19093
[19:57:47] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] Cleaning Bitcoin ABC Staging in /home/teamcity/buildAgent/work/jailed-build/bitcoin-abc the file set ALL_UNTRACKED
[19:57:47] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git clean -f -d -x
[19:57:47] : Build preparation done
[19:57:47]E: Step 1/2: Command Line (8s)
[19:57:47] :	 [Step 1/2] Ant JUnit report watcher
[19:57:47] :		 [Ant JUnit report watcher] Watching paths:
[19:57:47] :		 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[19:57:47] :		 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[19:57:47] :	 [Step 1/2] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script5970105054170032588
[19:57:47] :	 [Step 1/2] in directory: /home/teamcity/buildAgent/work/jailed-build
[19:57:47] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[19:57:47] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[19:57:47] :	 [Step 1/2] Building base image for: ca644d0f2...
[19:57:47] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[19:57:47] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[19:57:47] :	 [Step 1/2] Tag name: abc-base-image-ca644d0f2
[19:57:54]W:	 [Step 1/2] /bin/bash: -c: line 0: syntax error near unexpected token `;'
[19:57:54]W:	 [Step 1/2] /bin/bash: -c: line 0: `results() { set +e ;   cp -r /tmp/sanitizer_logs /results ;   cp -r -T /work/build /results ;   cp /work/ibd/debug.log /results ;   chown -R 1001 /work ;   chown -R 1001 /results ; } ; trap "results" EXIT ;  ; # depends cache ; #export BASE_CACHE=/root/abc-depends/cache ; #export SDK_PATH=/root/abc-depends/osx-sdk ; #export SOURCES_PATH=/root/abc-depends/sources ; #mkdir -p "" "" "" ;  ; ./contrib/teamcity/build-configurations.sh'
[19:57:54]W:	 [Step 1/2] Process exited with code 1
[19:57:54]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)
teamcity added a comment.Apr 24 2020, 20:01

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 24 2020, 20:01
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[20:01:21]i:	 [Collecting changes in 3 VCS roots] Will collect changes for 'ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc.git' starting from revision b9b2f8fb901be8a2b6a411919100bc2aa8f7f1b4
[20:01:22]i:	 [Collecting changes in 3 VCS roots] Detecting changes in VCS root 'Bitcoin ABC Staging' (used in 'Bitcoin ABC Diff Base Image (defunct)', 'Bitcoin-ABC Gitian Diff Testing' and 5 other configurations)
[20:01:22]i:	 [Collecting changes in 3 VCS roots] Will collect changes for 'Bitcoin ABC Staging' starting from revision 1678967611ccb25b630c4d8b93d406d7d20af191
[20:01:22] :	 [Collecting changes in 3 VCS roots] Compute revision for 'Bitcoin ABC Staging'
[20:01:22] :		 [Compute revision for 'Bitcoin ABC Staging'] Upper limit revision: ca644d0f20f9a033a0db1893f6279b50b40dacbe
[20:01:22]i:		 [Compute revision for 'Bitcoin ABC Staging'] MaxModId = 21278
[20:01:22] :		 [Compute revision for 'Bitcoin ABC Staging'] Latest commit attached to build configuration: ca644d0f20f9a033a0db1893f6279b50b40dacbe
[20:01:22] :		 [Compute revision for 'Bitcoin ABC Staging'] Computed revision: ca644d0f20f9a033a0db1893f6279b50b40dacbe
[20:01:25] : The build is removed from the queue to be prepared for the start
[20:01:28] : Starting the build on the agent highperf1
[20:01:28]i: Agent time zone: Etc/UTC
[20:01:28]i: Agent is running under JRE: 1.8.0_232-b09
[20:01:28] : Clearing temporary directory: /home/teamcity/buildAgent/temp/buildTmp
[20:01:28] : Publishing internal artifacts (2s)
[20:01:31] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[20:01:31] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[20:01:28] : Clean build enabled: removing old files from /home/teamcity/buildAgent/work/jailed-build
[20:01:28] : Checkout directory: /home/teamcity/buildAgent/work/jailed-build
[20:01:28] : Updating sources: agent side checkout (2s)
[20:01:28] :	 [Updating sources] VCS Root: Bitcoin ABC Staging (2s)
[20:01:28] :		 [VCS Root: Bitcoin ABC Staging] checkout rules: =>bitcoin-abc; revision: ca644d0f20f9a033a0db1893f6279b50b40dacbe
[20:01:28] :		 [VCS Root: Bitcoin ABC Staging] Git version: 2.20.1.0
[20:01:28] :		 [VCS Root: Bitcoin ABC Staging] Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git) (1s)
[20:01:28] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git config http.sslCAInfo
[20:01:28] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref
[20:01:29] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git -c credential.helper= ls-remote origin
[20:01:30] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref refs/tags/phabricator/diff/19093
[20:01:30] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git show-ref refs/tags/phabricator/diff/19093
[20:01:30] :			 [Update git mirror (/home/teamcity/buildAgent/system/git/git-48AA3180.git)] /usr/bin/git pack-refs --all
[20:01:30] :		 [VCS Root: Bitcoin ABC Staging] Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)
[20:01:30] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] The .git directory is missing in '/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc'. Running 'git init'...
[20:01:30] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git init
[20:01:30] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config lfs.storage /home/teamcity/buildAgent/system/git/git-48AA3180.git/lfs
[20:01:30] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config core.sparseCheckout true
[20:01:30] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git config http.sslCAInfo
[20:01:30] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref
[20:01:30] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/19093
[20:01:30] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git log -n1 --pretty=format:%H%x20%s ca644d0f20f9a033a0db1893f6279b50b40dacbe --
[20:01:30] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git -c credential.helper= checkout -q -f phabricator/diff/19093
[20:01:30] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git show-ref refs/tags/phabricator/diff/19093
[20:01:30] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] Cleaning Bitcoin ABC Staging in /home/teamcity/buildAgent/work/jailed-build/bitcoin-abc the file set ALL_UNTRACKED
[20:01:30] :			 [Update checkout directory (/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc)] /usr/bin/git clean -f -d -x
[20:01:30] : Build preparation done
[20:01:30]E: Step 1/2: Command Line (7s)
[20:01:30] :	 [Step 1/2] Ant JUnit report watcher
[20:01:30] :		 [Ant JUnit report watcher] Watching paths:
[20:01:30] :		 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[20:01:30] :		 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[20:01:30] :	 [Step 1/2] Starting: /home/teamcity/buildAgent/temp/agentTmp/custom_script7873913713771698457
[20:01:30] :	 [Step 1/2] in directory: /home/teamcity/buildAgent/work/jailed-build
[20:01:30] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[20:01:30] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[20:01:30] :	 [Step 1/2] Building base image for: ca644d0f2...
[20:01:30] :	 [Step 1/2] ~/buildAgent/work/jailed-build/bitcoin-abc ~/buildAgent/work/jailed-build
[20:01:30] :	 [Step 1/2] ~/buildAgent/work/jailed-build
[20:01:30] :	 [Step 1/2] Tag name: abc-base-image-ca644d0f2
[20:01:37]W:	 [Step 1/2] /bin/bash: -c: line 0: syntax error near unexpected token `;'
[20:01:37]W:	 [Step 1/2] /bin/bash: -c: line 0: `results() { set +e ;   cp -r /tmp/sanitizer_logs /results ;   cp -r -T /work/build /results ;   cp /work/ibd/debug.log /results ;   chown -R 1001 /work ;   chown -R 1001 /results ; } ; trap "results" EXIT ;  ; ./contrib/teamcity/build-configurations.sh'
[20:01:37]W:	 [Step 1/2] Process exited with code 1
[20:01:37]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)
teamcity added a comment.Apr 24 2020, 20:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 24 2020, 20:14

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10386: Diff 19093.Apr 24 2020, 20:14
majcosta added a child revision: D5839: [backport#15288] Remove uses of fPruneMode in wallet code.Apr 25 2020, 19:18
deadalnix added a subscriber: deadalnix.Apr 25 2020, 21:01
deadalnix added inline comments.
src/wallet/wallet.cpp
19

Shoudn't this header be removed?

deadalnix requested changes to this revision.Apr 25 2020, 21:05
This revision now requires changes to proceed.Apr 25 2020, 21:05
majcosta added inline comments.Apr 25 2020, 23:00
src/wallet/wallet.cpp
19

CWallet::SelectCoins still references DEFAULT_ANCESTOR/DESCENDENT_LIMIT, looks like they refactored that in https://github.com/bitcoin/bitcoin/commit/eea462de9c652dca556ad241d2126b10790f67f8

majcosta requested review of this revision.Apr 26 2020, 07:52
deadalnix accepted this revision.Apr 26 2020, 13:27
This revision is now accepted and ready to land.Apr 26 2020, 13:27
Closed by commit rABCbf1fc2dd8a7f: [backport#15288] Remove use of CalculateMemPoolAncestors in wallet code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyApr 27 2020, 07:04
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCbf1fc2dd8a7f: [backport#15288] Remove use of CalculateMemPoolAncestors in wallet code.
majcosta added a commit: rSTAGINGbf1fc2dd8a7f: [backport#15288] Remove use of CalculateMemPoolAncestors in wallet code.May 5 2020, 19:08

Revision Contents
Changeset List

PathSize
src/
interfaces/
4 lines
24 lines
wallet/
22 lines

Diff 19093

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...