Page MenuHomePhabricator
Differential D5839

[backport#15288] Remove uses of fPruneMode in wallet code
ClosedPublic
Actions

Authored by majcosta on Apr 25 2020, 19:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING154faf31ba11: [backport#15288] Remove uses of fPruneMode in wallet code
rABC154faf31ba11: [backport#15288] Remove uses of fPruneMode in wallet code
Summary

cc3836e8f90894432db06d9de6b20eac53d93cbe This commit does not change behavior. (Russell Yanofsky)

Depends on D5831

This is a partial backport of Core PR15288

Test Plan
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug -DBUILD_BITCOIN_WALLET=OFF
ninja check-all
cmake .. -GNinja -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15288
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10409
Build 18639: Default Diff Build & Tests
Build 18638: arc lint + arc unit

Event Timeline

majcosta created this revision.Apr 25 2020, 19:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 25 2020, 19:18
teamcity edited the summary of this revision. (Show Details)Apr 25 2020, 19:18

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 25 2020, 19:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 25 2020, 19:33

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10409: Diff 19126.Apr 25 2020, 19:33
deadalnix accepted this revision.Apr 25 2020, 21:02
This revision is now accepted and ready to land.Apr 25 2020, 21:02
majcosta added a child revision: D5840: [backport#15288] Remove uses of g_connman in wallet code.Apr 25 2020, 22:47
Closed by commit rABC154faf31ba11: [backport#15288] Remove uses of fPruneMode in wallet code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by majcosta). · Explain WhyApr 27 2020, 07:05
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC154faf31ba11: [backport#15288] Remove uses of fPruneMode in wallet code.
majcosta added a commit: rSTAGING154faf31ba11: [backport#15288] Remove uses of fPruneMode in wallet code.May 5 2020, 19:08

Revision Contents
Changeset List

PathSize
src/
interfaces/
3 lines
1 line
wallet/
8 lines
2 lines

Diff 19126

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...