Page MenuHomePhabricator
Differential D5983

[backport#15638] [build] Move rpc rawtransaction util functions to rpc/rawtransaction_util.cpp
ClosedPublic
Actions

Authored by majcosta on May 6 2020, 19:31.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING812563f7a7b6: [backport#15638] [build] Move rpc rawtransaction util functions to…
rABC812563f7a7b6: [backport#15638] [build] Move rpc rawtransaction util functions to…
Summary

rpc/rawtransaction.cpp moves to libbitcoin_server since it should not be
accessed by non-node libraries. The utility following utility methods
move to their own unit rpc/rawtransaction_util since they need to be
accessed by non-node libraries:

  • ConstructTransaction
  • TxInErrorToJSON
  • SignTransaction

https://github.com/bitcoin/bitcoin/pull/15638/commits/0509465542d63a5bbe7296f283f44dd491e74f78

Depends on D5979

This is a partial backport of Core PR15638

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15638
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10620
Build 19048: Default Diff Build & Tests
Build 19047: arc lint + arc unit

Event Timeline

majcosta created this revision.May 6 2020, 19:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2020, 19:31
majcosta requested review of this revision.May 6 2020, 19:31
teamcity edited the summary of this revision. (Show Details)May 6 2020, 19:31

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 6 2020, 19:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 6 2020, 19:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10620: Diff 19763.May 6 2020, 19:44
deadalnix accepted this revision.May 6 2020, 19:55
This revision is now accepted and ready to land.May 6 2020, 19:55
Closed by commit rABC812563f7a7b6: [backport#15638] [build] Move rpc rawtransaction util functions to… (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyMay 6 2020, 19:58
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC812563f7a7b6: [backport#15638] [build] Move rpc rawtransaction util functions to….
majcosta added a commit: rSTAGING812563f7a7b6: [backport#15638] [build] Move rpc rawtransaction util functions to….May 6 2020, 20:00
majcosta added a child revision: D5994: [backport#15638][build] Move several units into common libraries.May 7 2020, 12:34

Revision Contents
Changeset List

PathSize
src/
1 line
3 lines
rpc/
309 lines
rawtransaction_util.h
rawtransaction.h
9 lines
326 lines
wallet/
2 lines

Diff 19763

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/rpc/rawtransaction.h

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/rpc/rawtransaction_util.h

Loading...
View Options

src/rpc/rawtransaction_util.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...