Page MenuHomePhabricator
Differential D6228

Store key origin info in key metadata
ClosedPublic
Actions

Authored by nakihito on May 22 2020, 19:34.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCc4f1a7bf5d73: Store key origin info in key metadata
Summary

Store the master key fingerprint and derivation path in the
key metadata. hdKeypath is kept to indicate the seed and for
backwards compatibility, but all key derivation path output
uses the key origin info instead of hdKeypath.

Partial backport of Core PR14021
https://github.com/bitcoin/bitcoin/pull/14021/commits/eab63bc264a35cf21738e8535773e3d36524c3fe

Depends on D6227

Test Plan
ninja
ninja check

Diff Detail

Event Timeline

nakihito created this revision.May 22 2020, 19:34
Owners added a reviewer: Restricted Owners Package.May 22 2020, 19:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 22 2020, 19:34
nakihito requested review of this revision.May 22 2020, 19:34
teamcity edited the summary of this revision. (Show Details)May 22 2020, 19:34

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 22 2020, 19:35

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 22 2020, 19:35

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

nakihito added a child revision: D6229: Implement a function to add KeyOriginInfo to a wallet.May 22 2020, 19:37
teamcity added a comment.May 22 2020, 19:37

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

nakihito updated this revision to Diff 20541.May 22 2020, 19:42

Fixed some comment formatting.

teamcity added a comment.May 22 2020, 19:43

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 22 2020, 19:43

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 22 2020, 19:45

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 22 2020, 19:46

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 22 2020, 19:47

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

teamcity added a comment.May 22 2020, 19:47

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 22 2020, 19:49

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

Harbormaster completed remote builds in B10986: Diff 20538.May 22 2020, 19:51
teamcity added a comment.May 22 2020, 19:51

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 22 2020, 19:54

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10989: Diff 20541.May 22 2020, 19:54
deadalnix accepted this revision.May 22 2020, 21:35
This revision is now accepted and ready to land.May 22 2020, 21:35
Closed by commit rABCc4f1a7bf5d73: Store key origin info in key metadata (authored by Andrew Chow <achow101-github@achow101.com>, committed by nakihito). · Explain WhyMay 22 2020, 23:20
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCc4f1a7bf5d73: Store key origin info in key metadata.

Revision Contents
Changeset List

PathSize
src/
script/
13 lines
wallet/
7 lines
9 lines
10 lines
70 lines
17 lines
9 lines

Diff 20541

View Options

src/script/sign.h

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...